Page MenuHomePhabricator
Create Task
Maniphest T312224

Remove LanguageFallbackLabelDescriptionLookupFactory
Closed, ResolvedPublic
Actions

Description

Once T312223 has hopefully removed all uses of LanguageFallbackLabelDescriptionLookupFactory in favor of the new FallbackLabelDescriptionLookupFactory, remove the old factory.

Based on codesearch this would mean to make sure that this class is removed from at lest the following repositories:

  • Math
  • WikibaseCirrusSearch
  • ArticlePlaceholder
  • WikibaseLexemeCirrusSearch
  • WikibaseLexeme
  • Wikibase

Details

SubjectRepoBranchLines +/-
Fully remove LanguageFallbackLabelDescriptionLookupFactorymediawiki/extensions/Wikibasemaster+3 -291
Stop using LanguageFallbackLabelDescriptionLookupFactory in testsmediawiki/extensions/WikibaseLexememaster+6 -54
Hard-deprecate LanguageFallbackLabelDescriptionLookupFactorymediawiki/extensions/Wikibasemaster+17 -2
Replace LanguageFallbackLabelDescriptionLookupFactorymediawiki/extensions/WikibaseLexemeCirrusSearchmaster+22 -32
Resolve redirects in LexemeDescription for Special:Searchmediawiki/extensions/WikibaseLexemeCirrusSearchmaster+13 -120
Stop using LanguageFallbackLabelDescriptionLookupFactory in Scribunto_LuaWikibaseLibrarymediawiki/extensions/Wikibasemaster+55 -31
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jul 6 2022, 1:31 PM
Lucas_Werkmeister_WMDE mentioned this in T305032: Lexeme pages do not show labels of redirected Items (unlike Item pages).
karapayneWMDE added a project: Wikidata Dev Team (Sprint-∞).Jul 12 2022, 8:42 AM
karapayneWMDE moved this task from Parents/Waiting to Todo/Backlog on the Wikidata Dev Team (Sprint-∞) board.
Michael subscribed.Jul 13 2022, 11:41 AM
Michael updated the task description. (Show Details)Jul 13 2022, 1:10 PM
guergana.tzatchkova claimed this task.Jul 14 2022, 2:35 PM
guergana.tzatchkova moved this task from Todo/Backlog to Doing on the Wikidata Dev Team (Sprint-∞) board.
guergana.tzatchkova moved this task from Doing to Parents/Waiting on the Wikidata Dev Team (Sprint-∞) board.Jul 14 2022, 2:54 PM
guergana.tzatchkova removed guergana.tzatchkova as the assignee of this task.Jul 18 2022, 7:17 AM
guergana.tzatchkova subscribed.
gerritbot added a comment.Jul 25 2022, 10:36 AM

Change 816723 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Stop using LanguageFallbackLabelDescriptionLookupFactory in Scribunto_LuaWikibaseLibrary

https://gerrit.wikimedia.org/r/816723

gerritbot added a project: Patch-For-Review.Jul 25 2022, 10:36 AM
gerritbot added a comment.Jul 25 2022, 4:40 PM

Change 816723 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Stop using LanguageFallbackLabelDescriptionLookupFactory in Scribunto_LuaWikibaseLibrary

https://gerrit.wikimedia.org/r/816723

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.22; 2022-07-25).Jul 25 2022, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 25 2022, 5:30 PM
Michael updated the task description. (Show Details)Jul 25 2022, 5:44 PM
karapayneWMDE moved this task from Parents/Waiting to Todo/Backlog on the Wikidata Dev Team (Sprint-∞) board.Jul 26 2022, 9:06 AM
karapayneWMDE moved this task from Todo/Backlog to Parents/Waiting on the Wikidata Dev Team (Sprint-∞) board.
karapayneWMDE moved this task from Parents/Waiting to Todo/Backlog on the Wikidata Dev Team (Sprint-∞) board.
gerritbot added a comment.Jul 26 2022, 9:52 AM

Change 817213 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Stop using LanguageFallbackLabelDescriptionLookupFactory in tests

https://gerrit.wikimedia.org/r/817213

gerritbot added a project: Patch-For-Review.Jul 26 2022, 9:52 AM
gerritbot added a comment.Jul 26 2022, 2:59 PM

Change 817246 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Replace LanguageFallbackLabelDescriptionLookupFactory

https://gerrit.wikimedia.org/r/817246

gerritbot added a comment.Jul 26 2022, 2:59 PM

Change 817286 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Resolve redirects in LexemeDescription for Special:Search

https://gerrit.wikimedia.org/r/817286

Michael updated the task description. (Show Details)Jul 26 2022, 3:00 PM
gerritbot added a comment.Jul 27 2022, 1:29 PM

Change 817246 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Replace LanguageFallbackLabelDescriptionLookupFactory

https://gerrit.wikimedia.org/r/817246

gerritbot added a comment.Jul 27 2022, 1:29 PM

Change 817286 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Resolve redirects in LexemeDescription for Special:Search

https://gerrit.wikimedia.org/r/817286

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.23; 2022-08-01); removed MW-1.39-notes (1.39.0-wmf.22; 2022-07-25).Jul 27 2022, 2:00 PM
Michael mentioned this in rEWLCac479bd76db0: Replace LanguageFallbackLabelDescriptionLookupFactory.Jul 27 2022, 4:26 PM
Michael mentioned this in rEWLC2f7837bb33b9: Resolve redirects in LexemeDescription for Special:Search.
gerritbot added a comment.Jul 27 2022, 4:43 PM

Change 817828 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Hard-deprecate LanguageFallbackLabelDescriptionLookupFactory

https://gerrit.wikimedia.org/r/817828

Lucas_Werkmeister_WMDE moved this task from Todo/Backlog to Peer Review on the Wikidata Dev Team (Sprint-∞) board.Jul 27 2022, 4:44 PM
gerritbot added a comment.Jul 27 2022, 4:46 PM

Change 817830 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] WIP: Fully remove LanguageFallbackLabelDescriptionLookupFactory

https://gerrit.wikimedia.org/r/817830

gerritbot added a comment.Jul 27 2022, 5:35 PM

Change 817828 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Hard-deprecate LanguageFallbackLabelDescriptionLookupFactory

https://gerrit.wikimedia.org/r/817828

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jul 28 2022, 10:26 AM
gerritbot added a comment.Jul 28 2022, 10:27 AM

Change 817213 abandoned by Lucas Werkmeister (WMDE):

[mediawiki/extensions/WikibaseLexeme@master] Stop using LanguageFallbackLabelDescriptionLookupFactory in tests

Reason:

We want with I7b3c60098b instead.

https://gerrit.wikimedia.org/r/817213

Lucas_Werkmeister_WMDE removed projects: Patch-For-Review, Wikidata Dev Team (Sprint-∞), Wikidata-Campsite (Team A Hearth 🏰🔥).EditedJul 28 2022, 10:45 AM

Untagging the dev team for now; we’ll return to this and merge the last change after the 1.39 branch cut (T313920, scheduled for 5 September 2022).

gerritbot added a comment.Sep 7 2022, 1:13 PM

Change 817830 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Fully remove LanguageFallbackLabelDescriptionLookupFactory

https://gerrit.wikimedia.org/r/817830

Michael closed this task as Resolved.Sep 7 2022, 1:53 PM
Michael claimed this task.
Michael updated the task description. (Show Details)

The only things lef tin the codesearch are the two mentions of this class being deprecated and then removed in the 1.39 and 1.40 release notes respectively.

I think that concludes this task.

Restricted Application added a project: User-Michael. · View Herald TranscriptSep 7 2022, 1:54 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.1; 2022-09-12).Sep 7 2022, 2:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL