ZWrapper caching is broken
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

None

Authored By

	AAssaf
	Jul 6 2022, 2:15 PM

Description

ZWrapper.resolveKey() is supposed to return the resolved version of a zobject key. This was broken in https://github.com/wikimedia/mediawiki-services-function-orchestrator/commit/ffcb8e454e092f07501c8bbbafc30a0c48abd0df because when the key is an argument reference the resolved version is not stored, so resolveKey() returns the unresolved version.

Not sure how to fix it without breaking the original issue (https://phabricator.wikimedia.org/T310085).

	Project	Branch	Lines +/-	Subject
	mediawiki/services/function-orchestrator	master	+16 -28	Fix ZWrapper caching by storing the result of argument reference resolution.

		Status	Subtype	Assigned	Task
		Resolved		AAssaf	T309195 Wrong result due to dynamic scoping in function calls
		Resolved	BUG REPORT	None	T312227 ZWrapper caching is broken

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 811978 had a related patch set uploaded (by AAssaf; author: AAssaf):

[mediawiki/services/function-orchestrator@master] Fix ZWrapper caching by storing the result of argument reference resolution.

Change 811978 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Fix ZWrapper caching by storing the result of argument reference resolution.

AAssaf closed this task as Resolved.Jul 18 2022, 12:41 PM