Page MenuHomePhabricator

VisualEditor test failure in "Content Editable should save an edit"
Closed, ResolvedPublic

Description

Just got another one of these during gate and submit from an VE patch:

13:00:25 [Chrome 90.0.4430.212 linux #0-0] Content Editable
13:00:25 [Chrome 90.0.4430.212 linux #0-0]    ✓ should load when an url is opened @daily
13:00:25 [Chrome 90.0.4430.212 linux #0-0]    ✓ should be editable
13:00:25 [Chrome 90.0.4430.212 linux #0-0]    ✖ should save an edit
13:00:25 [Chrome 90.0.4430.212 linux #0-0]
13:00:25 [Chrome 90.0.4430.212 linux #0-0] 2 passing (18.4s)
13:00:25 [Chrome 90.0.4430.212 linux #0-0] 1 failing
13:00:25 [Chrome 90.0.4430.212 linux #0-0]
13:00:25 [Chrome 90.0.4430.212 linux #0-0] 1) Content Editable should save an edit
13:00:25 [Chrome 90.0.4430.212 linux #0-0] Can't call getText on element with selector "div.mw-notification-content span.oo-ui-labelElement-label" because element wasn't found
13:00:25 [Chrome 90.0.4430.212 linux #0-0] Error: Can't call getText on element with selector "div.mw-notification-content span.oo-ui-labelElement-label" because element wasn't found
13:00:25 [Chrome 90.0.4430.212 linux #0-0]     at implicitWait (/workspace/src/extensions/VisualEditor/node_modules/webdriverio/build/utils/implicitWait.js:34:19)
13:00:25 [Chrome 90.0.4430.212 linux #0-0]     at async Element.elementErrorHandlerCallbackFn (/workspace/src/extensions/VisualEditor/node_modules/webdriverio/build/middlewares.js:20:29)
13:00:25 [Chrome 90.0.4430.212 linux #0-0]     at async Element.wrapCommandFn (/workspace/src/extensions/VisualEditor/node_modules/@wdio/utils/build/shim.js:131:29)
13:00:25 [Chrome 90.0.4430.212 linux #0-0]     at async Context.<anonymous> (/workspace/src/extensions/VisualEditor/tests/selenium/specs/content_editable.js:57:23)

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-selenium-docker/128128/console

Event Timeline

Screen recording of the failing test: (copied from https://integration.wikimedia.org/ci/blue/organizations/jenkins/quibble-vendor-mysql-php72-selenium-docker/detail/quibble-vendor-mysql-php72-selenium-docker/128128/artifacts)

Final frame:

Content-Editable-should-save-an-edit-2022-07-06T11-00-15-281Z_Moment.jpg (1×1 px, 445 KB)

It looks like the post-edit notification indeed didn't come up, causing the failure. This might be related to the fact that the wiki uses FlaggedRevs?

zeljkofilipin claimed this task.

While working on T291254: Find flaky Selenium tests I've ran VisualEditor Selenium tests 100 times in a row in CI and no tests failed. See 807126. I assume this was just a very rare failure (less than 1%). It might be that Selenium tests are flaky or that there was a problem in CI. I'll resolve this task for now, since I can't reproduce the problem. Please reopen if it happens again.