Some applicable back & forth here on this ticket:

https://phabricator.wikimedia.org/T310275#8116241

Some group thoughts from engineering sync (no need for design input at this point)

• If subscription succeeds, show subscription state on button immediately. Show success toast or failure toast after subscription call goes through. If it fails, don’t worry about resetting subscription button state, it will change to the correct state the next time the user refreshes their screen.
• Look into what RMessage library can do for toasts (location, icons, buttons)
• Can we dedupe the first two error states in the mocks? Maybe just go with the first error state? It’ll take longer to build but better for the user.
• For no internet connection banner, try to figure that out ahead of time with our ReachabilityNotifier class and display whenever they see each view. Don’t wait for the call to fail - a "No internet connection" banner after typing their response is a bit cruel.

Things remaining to develop:

We haven't picked this up yet, so we still need to do everything here.

• Error upon first load, upon topic publish, upon reply publish, upon subscribe/unsubscribe
• No internet connection upon first load, upon topic publish, upon reply publish, upon subscribe/unsubscribe

Error with no fallback PR - https://github.com/wikimedia/wikipedia-ios/pull/4361

PR - other error states https://github.com/wikimedia/wikipedia-ios/pull/4367
PR - new topic error https://github.com/wikimedia/wikipedia-ios/pull/4374

@OTichonova in Task sync we discussed that the 'go to settings' link would only be able to open the device settings under 'Wikipedia' which does not give the user the opportunity to turn on Wifi. For this reason, we've proposed removing this link.

@Mazevedo Things are looking good! Would it be possible to add a shadow underneath the toasts and snack bars? The designs have a slight drop shadow, and right now it is not present. If we can't do a drop shadow, could we use a .5 pt top (for snack bars) or bottom (for toast) border using the 'border' color of each theme?

@cmadeo @OTichonova We can look into adding these borders/shadows - would you be okay with it applying to all banners throughout the app? That is, including those that are not a part of the talk page feature.

Design review PR (added a shadow): https://github.com/wikimedia/wikipedia-ios/pull/4384

@OTichonova

@Mazevedo noticed in code review that the Sepia theme displays a white background on all of these toasts. Would you like us to change that while we're in here? Thanks!

In T312314#8356422, @Tsevener wrote:

@cmadeo @OTichonova We can look into adding these borders/shadows - would you be okay with it applying to all banners throughout the app? That is, including those that are not a part of the talk page feature.

Hi Toni!
Sorry, I missed this earlier. Yes, that would be fine for consistency purposes, is it a lot of work to do this?

In T312314#8369807, @Tsevener wrote:

@OTichonova

@Mazevedo noticed in code review that the Sepia theme displays a white background on all of these toasts. Would you like us to change that while we're in here? Thanks!

Hi! Yes please, updating it to display the correct background color according to the theme would be great. Nice catch!

Sorry, I missed this earlier. Yes, that would be fine for consistency purposes, is it a lot of work to do this?

Nope! It's already done, feel free to take a look in the latest TestFlight. I'll move this back into Design Review column once we get that Sepia color updated.

@OTichonova I went with our chromeBackground theme color, but let me know if this looks off to you and I'll update it to whatever you need:

https://github.com/wikimedia/wikipedia-ios/pull/4389

Hi @Tsevener, looks good, thank you!

Hi!
Small UI change:
Could we increase the size of the icons in the toast to 22pts? And decrease the distance between the icon and the text to 12pts?

Thanks!

PR with icon tweaks https://github.com/wikimedia/wikipedia-ios/pull/4397

@OTichonova adding some screenshots to make review easier

Looks good to me on 7.0.0 (2010)