Page MenuHomePhabricator
Create Task
Maniphest T312320

IP Info: Links in the box should only be clickable on the text
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

follows up on T311032: IP Info: Add links to block log

From @dom_walden

the clickable part of the <a> element extends across the whole column (the blue area in the screenshot).

block_log_link.png (407×1 px, 85 KB)

AC:

  • The clickable part of the link should be limited to the text:
    • Logs
    • Global contributions
    • XTools

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update Xtools and contibution Links on Special:Contributions Infoboxmediawiki/extensions/WikimediaMessagesmaster+10 -9
Update Logs Link on Special:Contributions Infoboxmediawiki/extensions/IPInfomaster+4 -3
Customize query in gerrit

Related Objects

Event Timeline

• Prtksxna created this task.Jul 7 2022, 3:52 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 7 2022, 3:52 AM
• Prtksxna updated the task description. (Show Details)Jul 7 2022, 3:52 AM
• Prtksxna updated the task description. (Show Details)
• Prtksxna mentioned this in T311032: IP Info: Add links to block log.
• Prtksxna moved this task from Design to Triage/To be Estimated on the Anti-Harassment-Team board.
Tchanders set the point value for this task to 1.Jul 18 2022, 5:29 PM
Tchanders moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment-Team board.Jul 18 2022, 5:35 PM
Tchanders moved this task from Cards ready for development to AHaT Sprint 12: The Dutch Cap on the Anti-Harassment-Team board.Jul 19 2022, 1:29 PM
Tchanders edited projects, added Anti-Harassment-Team (AHaT Sprint 12: The Dutch Cap); removed Anti-Harassment-Team.
• AGueyte claimed this task.Aug 1 2022, 6:31 PM
• AGueyte moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment-Team (AHaT Sprint 12: The Dutch Cap) board.
• AGueyte moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment-Team (AHaT Sprint 12: The Dutch Cap) board.Aug 1 2022, 7:29 PM
ARamirez_WMF edited projects, added Anti-Harassment-Team (AHaT Sprint 13: The Magikarp Hat); removed Anti-Harassment-Team (AHaT Sprint 12: The Dutch Cap).Aug 2 2022, 4:59 PM
ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment-Team (AHaT Sprint 13: The Magikarp Hat) board.
gerritbot added a comment.Aug 3 2022, 2:24 PM

Change 819140 had a related patch set uploaded (by AGueyte; author: AGueyte):

[mediawiki/extensions/WikimediaMessages@master] Update Xtools and contibution Links on Special:Contributions Infobox

https://gerrit.wikimedia.org/r/819140

gerritbot added a project: Patch-For-Review.Aug 3 2022, 2:24 PM

Change 819139 had a related patch set uploaded (by AGueyte; author: AGueyte):

[mediawiki/extensions/IPInfo@master] Update Logs Link on Special:Contributions Infobox

https://gerrit.wikimedia.org/r/819139

• TThoabala moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment-Team (AHaT Sprint 13: The Magikarp Hat) board.Aug 3 2022, 5:08 PM
gerritbot added a comment.Aug 3 2022, 5:09 PM

Change 819139 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Update Logs Link on Special:Contributions Infobox

https://gerrit.wikimedia.org/r/819139

gerritbot added a comment.Aug 3 2022, 5:24 PM

Change 819140 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] Update Xtools and contibution Links on Special:Contributions Infobox

https://gerrit.wikimedia.org/r/819140

Maintenance_bot removed a project: Patch-For-Review.Aug 3 2022, 5:30 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 3 2022, 6:00 PM
dom_walden moved this task from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment-Team (AHaT Sprint 13: The Magikarp Hat) board.Aug 5 2022, 10:25 AM

Looks good to me. Tested all three links on Firefox, Chromium and Safari.

infobox_links.png (364×1 px, 51 KB)

• Prtksxna moved this task from Backlog to In Progress on the IP Info board.Aug 8 2022, 4:05 AM
• Prtksxna closed this task as Resolved.Aug 17 2022, 2:08 PM
• Prtksxna moved this task from In Progress to Closed on the IP Info board.Aug 17 2022, 2:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits