Page MenuHomePhabricator

Migrate usage of Database::select to SelectQueryBuilder in GlobalBlocking
Closed, ResolvedPublic

Description

Now that T243051: A query builder for MediaWiki core is done, this extension should migrate away from IDatabase::select() to SelectQueryBuilder.

It would improve readability of the code, avoids mistakes by passing the wrong order of arguments, etc.

For more information check T243051 and its documentation.

Note that query builder is a different paradigm and changes should not be one-to-one. For example, avoid using joinConds().

Event Timeline

Change 829313 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Convert uses of Database::select et. al. to the select query builder

https://gerrit.wikimedia.org/r/829313

Dreamy_Jazz triaged this task as Low priority.

Change 829313 abandoned by Dreamy Jazz:

[mediawiki/extensions/GlobalBlocking@master] Convert uses of Database::select et. al. to the select query builder

Reason:

Don't want the patch sitting around - abandoning as unlikely to be reviewed soon.

https://gerrit.wikimedia.org/r/829313

Change #1022615 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GlobalBlocking@master] Migrate to IReadableDatabase::newSelectQueryBuilder

https://gerrit.wikimedia.org/r/1022615

Change #1022615 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Migrate to IReadableDatabase::newSelectQueryBuilder

https://gerrit.wikimedia.org/r/1022615