Migrate usage of Database::select to SelectQueryBuilder in GrowthExperiments
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Maintenance_bot
	Jul 7 2022, 6:26 AM

Description

Now that T243051: A query builder for MediaWiki core is done, this extension should migrate away from IDatabase::select() to SelectQueryBuilder.

It would improve readability of the code, avoids mistakes by passing the wrong order of arguments, etc.

For more information check T243051 and its documentation.

Note that query builder is a different paradigm and changes should not be one-to-one. For example, avoid using joinConds().

Details

Subject	Repo	Branch	Lines +/-
Migrate several IDatabase::select calls	mediawiki/extensions/GrowthExperiments	master	+150 -225
MentorStatusManager: Move away from IDatabase::selectFieldValues	mediawiki/extensions/GrowthExperiments	master	+10 -10
DatabaseMentorStore: Move from IDatabase::select	mediawiki/extensions/GrowthExperiments	master	+16 -17

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Open	None	T311866 Migrate Database::select usages to SelectQueryBuilder (in WMF-deployed extensions)
Open	None	T313519 Migrate usage of Database::select to SelectQueryBuilder in extensions maintained by Growth team
Open	None	T312330 Migrate usage of Database::select to SelectQueryBuilder in GrowthExperiments
		· · ·

Event Timeline

Maintenance_bot created this task.Jul 7 2022, 6:26 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 7 2022, 6:26 AM

Ladsgroup added a project: GrowthExperiments.Jul 7 2022, 7:45 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 7 2022, 7:45 AM

Change 811908 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] DatabaseMentorStore: Move from IDatabase::select

https://gerrit.wikimedia.org/r/811908

gerritbot added a project: Patch-For-Review.Jul 7 2022, 8:50 AM

Change 811908 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] DatabaseMentorStore: Move from IDatabase::select

https://gerrit.wikimedia.org/r/811908

Maintenance_bot removed a project: Patch-For-Review.Jul 7 2022, 12:30 PM

Change 812407 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] MentorStatusManager: Move away from IDatabase::selectFieldValues

https://gerrit.wikimedia.org/r/812407

gerritbot added a project: Patch-For-Review.Jul 8 2022, 9:20 PM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 12 2022, 4:01 AM

Change 812407 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] MentorStatusManager: Move away from IDatabase::selectFieldValues

https://gerrit.wikimedia.org/r/812407

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.22; 2022-07-25); removed MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 20 2022, 1:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 20 2022, 1:29 PM

Tgr added a parent task: T313519: Migrate usage of Database::select to SelectQueryBuilder in extensions maintained by Growth team.Jul 21 2022, 3:58 PM

Tgr moved this task from Inbox to Upcoming Work on the Growth-Team board.Jul 27 2022, 3:36 AM

MShilova_WMF moved this task from Upcoming Work to Triaged on the Growth-Team board.Nov 7 2022, 6:23 PM

Change 959032 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Migrate several IDatabase::select calls

https://gerrit.wikimedia.org/r/959032

gerritbot added a project: Patch-For-Review.Sep 19 2023, 6:27 PM

Most of entries migrated in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/959032 above (thanks @Ladsgroup for the tool)!

Places that are still todo:

UncachedMenteeOverviewDataProvider and its mega-queries
- I did the simple ones in the patch above, but let's leave the really big ones (having hundreds of lines) for a separate patch.
- How would I migrate queries involving subqueries? It looks like I can just pass a SelectQueryBuilder to join() and call it a day?
Impact and its mega-query (migrated the easier part, but let's pay more attention to the bigger one)