Page MenuHomePhabricator

Migrate usage of Database::select to SelectQueryBuilder in TranslationNotifications
Closed, ResolvedPublic2 Estimated Story Points

Description

Now that T243051: A query builder for MediaWiki core is done, this extension should migrate away from IDatabase::select() to SelectQueryBuilder.

It would improve readability of the code, avoids mistakes by passing the wrong order of arguments, etc.

For more information check T243051 and its documentation.

Note that query builder is a different paradigm and changes should not be one-to-one. For example, avoid using joinConds().

Event Timeline

Change 836096 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/TranslationNotifications@master] Notify all, some or except some languages

https://gerrit.wikimedia.org/r/836096

Change 836096 merged by jenkins-bot:

[mediawiki/extensions/TranslationNotifications@master] Add option to notify all, selected or all except some languages

https://gerrit.wikimedia.org/r/836096

Nikerabbit triaged this task as Medium priority.Jan 16 2024, 7:07 AM

Change 992154 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/TranslationNotifications@master] Use Expression builder instead of raw SQL and deprecared methods

https://gerrit.wikimedia.org/r/992154

Wangombe changed the task status from Open to In Progress.Feb 12 2024, 7:45 AM
Wangombe claimed this task.

Change 992154 merged by jenkins-bot:

[mediawiki/extensions/TranslationNotifications@master] Use Expression builder instead of raw SQL and deprecated methods

https://gerrit.wikimedia.org/r/992154

abi_ subscribed.

Tested existing functionality on MediaWiki.org by sending a test translations to Odia translators. Nothing appears to be broken.

Change #1026654 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/TranslationNotifications@master] Migrate to IReadableDatabase::newSelectQueryBuilder

https://gerrit.wikimedia.org/r/1026654

Change #1026654 merged by jenkins-bot:

[mediawiki/extensions/TranslationNotifications@master] Migrate to IReadableDatabase::newSelectQueryBuilder

https://gerrit.wikimedia.org/r/1026654