Page MenuHomePhabricator

Migrate usage of Database::select to SelectQueryBuilder in CentralAuth
Open, Needs TriagePublic

Description

Now that T243051: A query builder for MediaWiki core is done, this extension should migrate away from IDatabase::select() to SelectQueryBuilder.

It would improve readability of the code, avoids mistakes by passing the wrong order of arguments, etc.

For more information check T243051 and its documentation.

Note that query builder is a different paradigm and changes should not be one-to-one. For example, avoid using joinConds().

Details

Show related patches Customize query in gerrit

Event Timeline

Change 812340 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@master] Convert DB selects to use SelectQueryBuilder

https://gerrit.wikimedia.org/r/812340

Change 812550 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@master] tests: Convert DB selects to use SelectQueryBuilder

https://gerrit.wikimedia.org/r/812550

Change 812551 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@master] api: Convert DB selects to use SelectQueryBuilder

https://gerrit.wikimedia.org/r/812551

Change 812552 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@master] GlobalRename: Convert DB selects to use SelectQueryBuilder

https://gerrit.wikimedia.org/r/812552

Change 812553 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@master] Special: Convert DB selects to use SelectQueryBuilder

https://gerrit.wikimedia.org/r/812553

Change 812554 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@master] User: Convert DB selects to use SelectQueryBuilder

https://gerrit.wikimedia.org/r/812554

Change 812559 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@master] maintenance: Convert DB selects to use SelectQueryBuilder (part 1)

https://gerrit.wikimedia.org/r/812559

Change 812550 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] tests: Convert DB selects to use SelectQueryBuilder

https://gerrit.wikimedia.org/r/812550

Change 812551 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] api: Convert DB selects to use SelectQueryBuilder

https://gerrit.wikimedia.org/r/812551

Change 812561 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@master] maintenance: Convert DB selects to use SelectQueryBuilder (part 2)

https://gerrit.wikimedia.org/r/812561

Change 812562 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@master] WikiSet: Convert DB selects to use SelectQueryBuilder

https://gerrit.wikimedia.org/r/812562

Change 812340 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] GlobalGroup: Convert DB selects to use SelectQueryBuilder

https://gerrit.wikimedia.org/r/812340

Change 812562 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] WikiSet: Convert DB selects to use SelectQueryBuilder

https://gerrit.wikimedia.org/r/812562

Change 812553 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Special: Convert DB selects to use SelectQueryBuilder

https://gerrit.wikimedia.org/r/812553

Change 812552 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] GlobalRename: Convert DB selects to use SelectQueryBuilder

https://gerrit.wikimedia.org/r/812552

Change 876050 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/CentralAuth@master] Revert "GlobalRename: Convert DB selects to use SelectQueryBuilder"

https://gerrit.wikimedia.org/r/876050

Change 876051 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/CentralAuth@wmf/1.40.0-wmf.17] Revert "GlobalRename: Convert DB selects to use SelectQueryBuilder"

https://gerrit.wikimedia.org/r/876051

Change 876051 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@wmf/1.40.0-wmf.17] Revert "GlobalRename: Convert DB selects to use SelectQueryBuilder"

https://gerrit.wikimedia.org/r/876051

Mentioned in SAL (#wikimedia-operations) [2023-01-06T00:59:14Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:876051|Revert "GlobalRename: Convert DB selects to use SelectQueryBuilder" (T326377 T312394)]]

Mentioned in SAL (#wikimedia-operations) [2023-01-06T01:01:01Z] <urbanecm@deploy1002> urbanecm and urbanecm: Backport for [[gerrit:876051|Revert "GlobalRename: Convert DB selects to use SelectQueryBuilder" (T326377 T312394)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-01-06T01:08:03Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:876051|Revert "GlobalRename: Convert DB selects to use SelectQueryBuilder" (T326377 T312394)]] (duration: 08m 48s)

Change 876050 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Revert "GlobalRename: Convert DB selects to use SelectQueryBuilder"

https://gerrit.wikimedia.org/r/876050

Change 881435 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@master] Revert "Revert "GlobalRename: Convert DB selects to use SelectQueryBuilder""

https://gerrit.wikimedia.org/r/881435

Change 881435 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Revert "Revert "GlobalRename: Convert DB selects to use SelectQueryBuilder""

https://gerrit.wikimedia.org/r/881435

Change 812559 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] maintenance: Convert DB selects to use SelectQueryBuilder (part 1)

https://gerrit.wikimedia.org/r/812559

Change 812561 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] maintenance: Convert DB selects to use SelectQueryBuilder (part 2)

https://gerrit.wikimedia.org/r/812561

Change 1003090 had a related patch set uploaded (by Bartosz Dziewoński; author: Zabe):

[mediawiki/extensions/CentralAuth@master] CentralAuthUser: Convert some DB selects to use SelectQueryBuilder

https://gerrit.wikimedia.org/r/1003090

Change 1003090 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] CentralAuthUser: Convert some DB selects to use SelectQueryBuilder

https://gerrit.wikimedia.org/r/1003090

Change 1003110 had a related patch set uploaded (by African Hope; author: African Hope):

[mediawiki/extensions/CentralAuth@master] Maintenance: Convert DB selects to use SelectQueryBuilder

https://gerrit.wikimedia.org/r/1003110

Change 1003110 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Maintenance: Move away from wfGetDB()

https://gerrit.wikimedia.org/r/1003110