Page MenuHomePhabricator

<gallery> syntax is not valid xhtml 1.0
Closed, ResolvedPublic

Description

Author: wiki.bugzilla

Description:
gallery syntax is parsed in a wrong way, the problem exists for every gallery on
commons at the moment; compare these validation results http://validator.w3.org/
check?uri=http%3A%2F%2Fcommons.wikimedia.org%2Fwiki%2FAcropolis for example


Version: 1.4.x
Severity: normal
URL: http://commons.wikimedia.org/wiki/Acropolis

Details

Reference
bz1124

Related Objects

Event Timeline

bzimport raised the priority of this task from to High.Nov 21 2014, 8:07 PM
bzimport added a project: MediaWiki-General.
bzimport set Reference to bz1124.
bzimport added a subscriber: Unknown Object (MLST).
bzimport created this task.Dec 18 2004, 2:40 AM
brion added a comment.Dec 18 2004, 2:41 AM

Added blocking on XHTML tracking bug 209

zigger wrote:

Patches ImageGallery.php for HEAD

attachment ImageGallery.php.patch ignored as obsolete

zigger wrote:

Patches ImageGallery.php for REL1_4

attachment ImageGallery.php.patch ignored as obsolete

ejsanders wrote:

Proposed fix to ImageGallery.php

Image galleries are now valid xhtml, and look a bit more like the current image
boxes. Positioning is done with calculated padding to achieve vertical
alignment as XHTML/CSS can't do vertical alignment (beyond aligning inline
images against their text, it really is impossible). The other fixes still use
the height property of TD , which is only accepted in XHTML 1.0 Transistional,
not Strict.

Sorry, but I don't know how to do diffs :(.

Attached:

paddyez wrote:

On
[http://commons.wikimedia.org/wiki/Commons_talk:MediaWiki_1.4_upgrade#Galleries_not_valid_XHTML_1.0_trans.
commons] there is already a short discussion about this. First the attribute
valign="center" does not do anything at all (you could write foo="FU" instead)!
But the attribute "height" has an effect all major brwosers. This is a disaster
and the reason why I reset the priority. --~~~~

kl wrote:

<table height="XXpx"> is nonsence. What the browsers like is <table height="XX">
(without unit!!!). And what both, browsers AND HTML Spec like, is <table
style="height:XXpx;">.

jeluf wrote:

Fixed in CVS HEAD, based on patch provided by Ed Sanders.

ImageGallery.php, revision 1.15, and lots of CSS files.

jeluf wrote:

Fixed in REL1_4