Page MenuHomePhabricator
Create Task
Maniphest T312422

Migrate usage of Database::select to SelectQueryBuilder in Translate
Closed, ResolvedPublic
Actions

Description

Now that T243051: A query builder for MediaWiki core is done, this extension should migrate away from IDatabase::select() to SelectQueryBuilder.

It would improve readability of the code, avoids mistakes by passing the wrong order of arguments, etc.

For more information check T243051 and its documentation.

Note that query builder is a different paradigm and changes should not be one-to-one. For example, avoid using joinConds().

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Migrate TranslationStatsDataProvider to SelectQueryBuildermediawiki/extensions/Translatemaster+8 -1
TranslatorInterface: Migrate to IReadableDatabase::newSelectQueryBuildermediawiki/extensions/Translatemaster+44 -36
Migrate to IReadableDatabase::newSelectQueryBuildermediawiki/extensions/Translatemaster+57 -46
MessageLoading: Migrate to IReadableDatabase::newSelectQueryBuildermediawiki/extensions/Translatemaster+76 -75
messagegroups: Migrate to IReadableDatabase::newSelectQueryBuildermediawiki/extensions/Translatemaster+49 -32
Statistics: Migrate to IReadableDatabase::newSelectQueryBuildermediawiki/extensions/Translatemaster+62 -61
scripts: Migrate to IReadableDatabase::newSelectQueryBuildermediawiki/extensions/Translatemaster+60 -68
Use SelectQueryBuilder in TranslateSandbox::classmediawiki/extensions/Translatemaster+11 -11
Use SelectQueryBuilder in more placesmediawiki/extensions/Translatemaster+39 -46
PageTranslationSpecialPage: Use SelectQueryBuildermediawiki/extensions/Translatemaster+17 -19
DatabaseTTMServer: Move to namespacemediawiki/extensions/Translatemaster+66 -69
QueryMessageTranslationsActionApi: Add strict types; move to namespacemediawiki/extensions/Translatemaster+55 -53
Move Languageeditstats to Statistics namespacemediawiki/extensions/Translatemaster+126 -168
Move MessageGroups.php into MessageGroupProcessingmediawiki/extensions/Translatemaster+208 -191
QueryMessageCollectionActionApi: add strict types and move to namespacemediawiki/extensions/Translatemaster+78 -47
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Maintenance_bot created this task.Jul 7 2022, 6:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 7 2022, 6:27 AM
Ladsgroup added a project: MediaWiki-extensions-Translate.Jul 7 2022, 6:56 AM
Pginer-WMF triaged this task as Medium priority.Jul 18 2022, 11:18 AM
Pginer-WMF moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.
gerritbot added a comment.Jul 18 2022, 12:52 PM

Change 813610 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] QueryMessageCollectionActionApi: add strict types and move to namespace

https://gerrit.wikimedia.org/r/813610

gerritbot added a project: Patch-For-Review.Jul 18 2022, 12:52 PM
gerritbot added a comment.Jul 19 2022, 3:55 PM

Change 813610 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] QueryMessageCollectionActionApi: add strict types and move to namespace

https://gerrit.wikimedia.org/r/813610

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.22; 2022-07-25).Jul 19 2022, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 19 2022, 4:30 PM
gerritbot added a comment.Jul 20 2022, 10:39 AM

Change 815299 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] QueryMessageTranslationsActionApi: Add strict types; move to namespace

https://gerrit.wikimedia.org/r/815299

gerritbot added a project: Patch-For-Review.Jul 20 2022, 10:39 AM
gerritbot added a comment.Jul 20 2022, 2:36 PM

Change 815299 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] QueryMessageTranslationsActionApi: Add strict types; move to namespace

https://gerrit.wikimedia.org/r/815299

Maintenance_bot removed a project: Patch-For-Review.Jul 20 2022, 3:30 PM
gerritbot added a comment.Sep 28 2022, 6:58 AM

Change 836096 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/TranslationNotifications@master] WIP: Notify all, some or except some languages

https://gerrit.wikimedia.org/r/836096

gerritbot added a project: Patch-For-Review.Sep 28 2022, 6:58 AM
gerritbot added a comment.Nov 28 2022, 12:29 PM

Change 861381 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Move MessageGroups.php into MessageGroupProcessing

https://gerrit.wikimedia.org/r/861381

gerritbot added a comment.Nov 29 2022, 6:49 AM

Change 861718 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/CentralNotice@master] Update references to MessageGroups::class As part of: Ib8e39e6de6d7707a69fc152f4d25245cd4003ec8

https://gerrit.wikimedia.org/r/861718

gerritbot added a comment.Nov 29 2022, 6:52 AM

Change 861719 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/TwnMainPage@master] Update references to MessageGroups::class

https://gerrit.wikimedia.org/r/861719

gerritbot added a comment.Nov 29 2022, 7:54 AM

Change 861715 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/TranslationNotifications@master] Update reference to MessageGroups::class

https://gerrit.wikimedia.org/r/861715

gerritbot added a comment.Dec 7 2022, 7:56 AM

Change 865574 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Move MessageGroups.php into MessageGroupProcessing

https://gerrit.wikimedia.org/r/865574

gerritbot added a comment.Dec 14 2022, 12:58 PM

Change 861381 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Move MessageGroups.php into MessageGroupProcessing

https://gerrit.wikimedia.org/r/861381

gerritbot added a comment.Jan 18 2023, 6:29 AM

Change 881064 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Optimize languageeditstats::translationChanges

https://gerrit.wikimedia.org/r/881064

gerritbot added a comment.Feb 16 2023, 5:29 AM

Change 881064 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Move Languageeditstats to Statistics namespace

https://gerrit.wikimedia.org/r/881064

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.24; 2023-02-20).Feb 16 2023, 6:00 AM
gerritbot added a comment.Apr 25 2023, 10:18 AM

Change 911757 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] DatabaseTTMServer: Move to namespace

https://gerrit.wikimedia.org/r/911757

gerritbot added a comment.Apr 25 2023, 10:40 AM

Change 911757 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] DatabaseTTMServer: Move to namespace

https://gerrit.wikimedia.org/r/911757

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 15 2023, 9:02 PM
gerritbot added a comment.Sep 18 2023, 7:02 AM

Change 958391 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] PageTranslationSpecialPage: Use SelectQueryBuilder

https://gerrit.wikimedia.org/r/958391

gerritbot added a comment.Sep 19 2023, 9:02 AM

Change 958391 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] PageTranslationSpecialPage: Use SelectQueryBuilder

https://gerrit.wikimedia.org/r/958391

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.28; 2023-09-26); removed MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).Sep 19 2023, 1:01 PM
gerritbot added a comment.Oct 2 2023, 11:06 AM

Change 962571 had a related patch set uploaded (by Nikerabbit; author: Nikerabbit):

[mediawiki/extensions/Translate@master] Use SelectQueryBuilder in more places

https://gerrit.wikimedia.org/r/962571

gerritbot added a comment.Oct 10 2023, 8:24 AM

Change 962571 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Use SelectQueryBuilder in more places

https://gerrit.wikimedia.org/r/962571

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.1; 2023-10-17).Oct 10 2023, 9:00 AM
gerritbot added a comment.Nov 14 2023, 1:25 PM

Change 974181 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Use SelectQueryBuilder in TranslateSandbox::class

https://gerrit.wikimedia.org/r/974181

gerritbot added a comment.Nov 28 2023, 10:05 AM

Change 974181 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Use SelectQueryBuilder in TranslateSandbox::class

https://gerrit.wikimedia.org/r/974181

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.9; 2023-12-12); removed MW-1.42-notes (1.42.0-wmf.1; 2023-10-17).Nov 28 2023, 11:00 AM
gerritbot added a comment.Apr 29 2024, 9:13 PM

Change #1025469 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Translate@master] scripts: Migrate to IReadableDatabase::newSelectQueryBuilder

https://gerrit.wikimedia.org/r/1025469

gerritbot added a comment.Apr 30 2024, 4:45 AM

Change #1025469 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] scripts: Migrate to IReadableDatabase::newSelectQueryBuilder

https://gerrit.wikimedia.org/r/1025469

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.4; 2024-05-07).Apr 30 2024, 5:00 AM
gerritbot added a comment.May 1 2024, 2:04 PM

Change #1026146 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Translate@master] Statistics: Migrate to IReadableDatabase::newSelectQueryBuilder

https://gerrit.wikimedia.org/r/1026146

gerritbot added a comment.May 1 2024, 2:05 PM

Change #1026147 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Translate@master] TranslatorInterface: Migrate to IReadableDatabase::newSelectQueryBuilder

https://gerrit.wikimedia.org/r/1026147

gerritbot added a comment.May 1 2024, 2:07 PM

Change #1026148 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Translate@master] MessageLoading: Migrate to IReadableDatabase::newSelectQueryBuilder

https://gerrit.wikimedia.org/r/1026148

gerritbot added a comment.May 1 2024, 2:07 PM

Change #1026149 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Translate@master] messagegroups: Migrate to IReadableDatabase::newSelectQueryBuilder

https://gerrit.wikimedia.org/r/1026149

gerritbot added a comment.May 1 2024, 2:08 PM

Change #1026150 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Translate@master] translation: Migrate to IReadableDatabase::newSelectQueryBuilder

https://gerrit.wikimedia.org/r/1026150

Umherirrender added a subtask: T363938: Replace TranslationStatsInterface::preQuery with a SelectQueryBuilder.May 1 2024, 7:31 PM
gerritbot added a comment.May 3 2024, 9:11 AM

Change #1026146 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Statistics: Migrate to IReadableDatabase::newSelectQueryBuilder

https://gerrit.wikimedia.org/r/1026146

gerritbot added a comment.May 3 2024, 10:23 AM

Change #1026149 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] messagegroups: Migrate to IReadableDatabase::newSelectQueryBuilder

https://gerrit.wikimedia.org/r/1026149

gerritbot added a comment.May 3 2024, 4:44 PM

Change #1026148 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] MessageLoading: Migrate to IReadableDatabase::newSelectQueryBuilder

https://gerrit.wikimedia.org/r/1026148

gerritbot added a comment.May 3 2024, 8:46 PM

Change #1026150 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Migrate to IReadableDatabase::newSelectQueryBuilder

https://gerrit.wikimedia.org/r/1026150

gerritbot added a comment.May 4 2024, 10:02 AM

Change #1026147 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] TranslatorInterface: Migrate to IReadableDatabase::newSelectQueryBuilder

https://gerrit.wikimedia.org/r/1026147

gerritbot added a comment.May 5 2024, 2:54 PM

Change #1027606 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Translate@master] Migrate TranslationStatsDataProvider to SelectQueryBuilder

https://gerrit.wikimedia.org/r/1027606

gerritbot added a comment.May 5 2024, 7:08 PM

Change #1027606 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Migrate TranslationStatsDataProvider to SelectQueryBuilder

https://gerrit.wikimedia.org/r/1027606

Umherirrender closed this task as Resolved.May 5 2024, 7:23 PM
Umherirrender removed a project: Patch-For-Review.
abi_ closed subtask T363938: Replace TranslationStatsInterface::preQuery with a SelectQueryBuilder as Resolved.Sep 6 2024, 7:43 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits