Now that T243051: A query builder for MediaWiki core is done, this extension should migrate away from IDatabase::select() to SelectQueryBuilder.
It would improve readability of the code, avoids mistakes by passing the wrong order of arguments, etc.
For more information check T243051 and its documentation.
Note that query builder is a different paradigm and changes should not be one-to-one. For example, avoid using joinConds().
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| [WIP] Migrate to query builders and expression builders | mediawiki/extensions/SecurePoll | master | +361 -544 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T311866 Migrate Database::select usages to SelectQueryBuilder (in WMF-deployed extensions) | |||
| Open | None | T312449 Migrate usage of Database::select to SelectQueryBuilder in SecurePoll |
Change 979120 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):
[mediawiki/extensions/SecurePoll@master] [WIP] Migrate to query builders and expression builders
Change 979120 abandoned by Ladsgroup:
[mediawiki/extensions/SecurePoll@master] [WIP] Migrate to query builders and expression builders
Reason:
It's way too big for one change and on top, it feels like putting a bowtie on a pig. The extension needs a full refactor how it's making db queries, they are all over the place.