Page MenuHomePhabricator

Migrate usage of Database::select to SelectQueryBuilder in MobileFrontend
Closed, DuplicatePublic


Now that T243051: A query builder for MediaWiki core is done, this extension should migrate away from IDatabase::select() to SelectQueryBuilder.

It would improve readability of the code, avoids mistakes by passing the wrong order of arguments, etc.

For more information check T243051 and its documentation.

Note that query builder is a different paradigm and changes should not be one-to-one. For example, avoid using joinConds().

Event Timeline

Jdlrobson changed the task status from Open to Stalled.Dec 13 2023, 10:24 PM

Will become unnecessary after T353388

Change #1023940 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MobileFrontend@master] Migrate to IReadableDatabase::newSelectQueryBuilder

Change #1023940 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Migrate to IReadableDatabase::newSelectQueryBuilder