Migrate usage of Database::select to SelectQueryBuilder in DiscussionTools
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Maintenance_bot
	Jul 7 2022, 6:28 AM

Description

Now that T243051: A query builder for MediaWiki core is done, this extension should migrate away from IDatabase::select() to SelectQueryBuilder.

It would improve readability of the code, avoids mistakes by passing the wrong order of arguments, etc.

For more information check T243051 and its documentation.

Note that query builder is a different paradigm and changes should not be one-to-one. For example, avoid using joinConds().

	Subject	Repo	Branch	Lines +/-
	Migrate usage of Database::select (and friends) to SelectQueryBuilder	mediawiki/extensions/DiscussionTools	master	+44 -45

		Status	Subtype	Assigned	Task
		Open		None	T311866 Migrate Database::select usages to SelectQueryBuilder (in WMF-deployed extensions)
		Resolved		matmarex	T312466 Migrate usage of Database::select to SelectQueryBuilder in DiscussionTools

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 7 2022, 6:28 AM

Change 822693 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Migrate usage of Database::select (and friends) to SelectQueryBuilder

Change 822693 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Migrate usage of Database::select (and friends) to SelectQueryBuilder

matmarex closed this task as Resolved.Aug 16 2022, 3:26 PM