Page MenuHomePhabricator
Create Task
Maniphest T312479

Migrate usage of Database::select to SelectQueryBuilder in CheckUser
Closed, ResolvedPublic
Actions

Description

Now that T243051: A query builder for MediaWiki core is done, this extension should migrate away from IDatabase::select() to SelectQueryBuilder.

It would improve readability of the code, avoids mistakes by passing the wrong order of arguments, etc.

For more information check T243051 and its documentation.

Note that query builder is a different paradigm and changes should not be one-to-one. For example, avoid using joinConds().

Details

SubjectRepoBranchLines +/-
Convert maintenance scripts to SelectQueryBuildermediawiki/extensions/CheckUsermaster+60 -49
Convert DB queries to use SelectQueryBuildermediawiki/extensions/CheckUsermaster+131 -148
Customize query in gerrit

Related Objects
Search...

Event Timeline

Maintenance_bot created this task.Jul 7 2022, 6:28 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 7 2022, 6:28 AM
Ladsgroup added a project: CheckUser.Jul 7 2022, 6:37 AM
Dreamy_Jazz subscribed.Jul 7 2022, 9:09 PM

Looking into this.

gerritbot added a comment.Jul 7 2022, 11:28 PM

Change 812101 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Convert DB queries to use SelectQueryBuilder in SpecialCheckUser.php

https://gerrit.wikimedia.org/r/812101

gerritbot added a project: Patch-For-Review.Jul 7 2022, 11:28 PM
Dreamy_Jazz claimed this task.Jul 7 2022, 11:50 PM
Dreamy_Jazz triaged this task as Low priority.

Made a patch for this so self-assigning.

Dreamy_Jazz moved this task from General / Unsorted to Patches for review on the CheckUser board.Jul 8 2022, 8:54 AM
Dreamy_Jazz moved this task from Unsorted to Migrate / Replace on the Technical-Debt board.Jul 8 2022, 9:02 AM
Ladsgroup subscribed.Jul 8 2022, 7:21 PM

I +2'd the patch but let's keep it open for some possible clean ups.

gerritbot added a comment.Jul 8 2022, 7:38 PM

Change 812101 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Convert DB queries to use SelectQueryBuilder

https://gerrit.wikimedia.org/r/812101

Maintenance_bot removed a project: Patch-For-Review.Jul 8 2022, 8:31 PM
Dreamy_Jazz added a comment.Jul 8 2022, 10:55 PM

The maintenance scripts probably need converting too which I didn't tackle in the last patch.

Dreamy_Jazz added a comment.Jul 8 2022, 11:28 PM

Also Special:Investigate related code needs to be converted

gerritbot added a comment.Jul 8 2022, 11:32 PM

Change 812421 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Convert maintenance scripts to SelectQueryBuilder

https://gerrit.wikimedia.org/r/812421

gerritbot added a project: Patch-For-Review.Jul 8 2022, 11:32 PM
gerritbot added a comment.Jul 9 2022, 7:02 PM

Change 812421 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Convert maintenance scripts to SelectQueryBuilder

https://gerrit.wikimedia.org/r/812421

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 12 2022, 6:02 AM
Tchanders added a project: Anti-Harassment.Aug 8 2022, 4:32 PM
Tchanders moved this task from Untriaged to CheckUser on the Anti-Harassment board.
Dreamy_Jazz removed Dreamy_Jazz as the assignee of this task.Aug 14 2022, 4:40 PM
Dreamy_Jazz moved this task from Patches for review to Investigate on the CheckUser board.

Unassigning so that Investigate code can be dealt with by Anti-Harrassment if they want to.

Tchanders mentioned this in T316433: Migrate usage of Database::select to SelectQueryBuilder in CheckUser's CompareService.Aug 27 2022, 1:24 PM
Tchanders mentioned this in T316434: Migrate usage of Database::select to SelectQueryBuilder in CheckUser's TimelineRowFormatter.
Tchanders mentioned this in T316435: Migrate usage of Database::select to SelectQueryBuilder in CheckUser's PreliminaryCheckService.
Dreamy_Jazz moved this task from Investigate to General / Unsorted on the CheckUser board.Aug 27 2022, 6:17 PM
Dreamy_Jazz removed a project: Patch-For-Review.Aug 27 2022, 9:03 PM
Dreamy_Jazz closed this task as Resolved.Sep 29 2022, 6:17 PM
Dreamy_Jazz claimed this task.

This should now be done as I cannot find any more uses in CheckUser.

Dreamy_Jazz closed subtask T316433: Migrate usage of Database::select to SelectQueryBuilder in CheckUser's CompareService as Resolved.Sep 30 2022, 11:44 AM
Dreamy_Jazz closed subtask T316434: Migrate usage of Database::select to SelectQueryBuilder in CheckUser's TimelineRowFormatter as Resolved.
Dreamy_Jazz closed subtask T316435: Migrate usage of Database::select to SelectQueryBuilder in CheckUser's PreliminaryCheckService as Resolved.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL