Maniphest T312482

Migrate usage of Database::select to SelectQueryBuilder in ReadingLists
Closed, ResolvedPublic
Actions

Description

Now that T243051: A query builder for MediaWiki core is done, this extension should migrate away from IDatabase::select() to SelectQueryBuilder.

It would improve readability of the code, avoids mistakes by passing the wrong order of arguments, etc.

For more information check T243051 and its documentation.

Note that query builder is a different paradigm and changes should not be one-to-one. For example, avoid using joinConds().

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Migrate to Select query builders	mediawiki/extensions/ReadingLists	master	+90 -105
	Migrate to Select query builders	mediawiki/extensions/ReadingLists	master	+198 -164

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T311866 Migrate Database::select usages to SelectQueryBuilder (in WMF-deployed extensions)
		Resolved		Atieno	T312482 Migrate usage of Database::select to SelectQueryBuilder in ReadingLists

Event Timeline

Maintenance_bot created this task.Jul 7 2022, 6:28 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 7 2022, 6:28 AM

Ladsgroup added a project: Reading List Service.Jul 7 2022, 6:37 AM

Restricted Application added a project: Product-Infrastructure-Team-Backlog-Deprecated. · View Herald TranscriptJul 7 2022, 6:37 AM

• JMcLeod_WMF moved this task from Needs triage to Upcoming on the Product-Infrastructure-Team-Backlog-Deprecated board.Sep 29 2022, 2:15 PM

• FJoseph-WMF assigned this task to Atieno.Nov 20 2023, 1:19 PM

Change 983136 had a related patch set uploaded (by Atieno; author: Atieno):

[mediawiki/extensions/ReadingLists@master] Migrate to Select query builders

https://gerrit.wikimedia.org/r/983136

gerritbot added a project: Patch-For-Review.Dec 14 2023, 8:52 AM

Change 983136 merged by jenkins-bot:

[mediawiki/extensions/ReadingLists@master] Migrate to Select query builders

https://gerrit.wikimedia.org/r/983136

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.10; 2023-12-19).Dec 15 2023, 2:00 PM

Atieno closed this task as Resolved.Dec 15 2023, 2:03 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 15 2023, 2:10 PM

Atieno added a project: MediaWiki CodeJam Dec 2023.Dec 15 2023, 4:19 PM

Atieno moved this task from Incoming to Done / Ready for Showcase on the MediaWiki CodeJam Dec 2023 board.

There are still many calls to Database::select* left in the extension, in FixListSize, ReadingListRepository,PopulateWithTestData, etc.

Noted..

Atieno added a project: API Platform.Jan 2 2024, 4:15 PM

Atieno moved this task from Incoming to Must do now on the API Platform board.Jan 2 2024, 4:17 PM

Atieno added a project: User-Atieno.Jan 2 2024, 4:29 PM

Atieno moved this task from Backlog to Current on the User-Atieno board.

Change 988414 had a related patch set uploaded (by Atieno; author: Atieno):

[mediawiki/extensions/ReadingLists@master] Migrate to Select query builders

https://gerrit.wikimedia.org/r/988414

gerritbot added a project: Patch-For-Review.Jan 8 2024, 9:57 AM

Atieno moved this task from Current to In Code Review on the User-Atieno board.Jan 8 2024, 1:28 PM

Change 988414 merged by jenkins-bot:

[mediawiki/extensions/ReadingLists@master] Migrate to Select query builders

https://gerrit.wikimedia.org/r/988414

Atieno closed this task as Resolved.Jan 9 2024, 4:28 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 9 2024, 4:30 PM

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.14; 2024-01-16); removed MW-1.42-notes (1.42.0-wmf.10; 2023-12-19).Jan 9 2024, 5:00 PM