Page MenuHomePhabricator

Migrate usage of Database::select to SelectQueryBuilder in OpenStackManager
Closed, InvalidPublic

Description

Now that T243051: A query builder for MediaWiki core is done, this extension should migrate away from IDatabase::select() to SelectQueryBuilder.

It would improve readability of the code, avoids mistakes by passing the wrong order of arguments, etc.

For more information check T243051 and its documentation.

Note that query builder is a different paradigm and changes should not be one-to-one. For example, avoid using joinConds().

Event Timeline

@Ladsgroup did you just mass file bugs against every extension or did you check beforehand they have DB code? I don't see anything in OSM, but I could be missing something here..

::select() is so common that it made sense to just create it against all extensions and close the ones that don't have it.