Add image: filter suggestions to prevent invalid source type errors
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	kostajh
	Jul 7 2022, 10:04 AM

Description

While attempting to deploy https://gerrit.wikimedia.org/r/808208, we noticed a high frequency of "invalid source type" errors:

[df7c8904-0c7f-48c3-aaab-03df3d947754] /w/index.php?title=Arabsk%C3%A1_hudba&getasktype=image-recommendation&gesuggestededit=1&geclickid=ulh3kh9nh3f4rav3kngrp97ok2d2bb1l&genewcomertasktoken=32ki8ubce0o9hrj16vgrvemcn5mia9l0&veaction=edit&section=all   Exception: Invalid source type for Arabská_hudba: `.

Let's fix those in the filtering/sorting step, then try again.

Details

Subject	Repo	Branch	Lines +/-
maintenance: Add getImageSuggestionData script	mediawiki/extensions/GrowthExperiments	master	+120 -15
ServiceImageRecommendationProvider: Don't fail on first validation error	mediawiki/extensions/GrowthExperiments	wmf/1.39.0-wmf.18	+2 -1
ServiceImageRecommendationProvider: Don't fail on first validation error	mediawiki/extensions/GrowthExperiments	wmf/1.39.0-wmf.19	+2 -1
ServiceImageRecommendationProvider: Don't fail on first validation error	mediawiki/extensions/GrowthExperiments	master	+2 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		• sdkim	T289582 <Path to Production> Image Suggestions POC
Resolved		sbassett	T294362 Image Suggestions POC Deprecation & Plan for Production
Resolved	Feature	kostajh	T306032 Adapt GrowthExperiments to new Image Suggestions API
Resolved		kostajh	T312521 Add image: filter suggestions to prevent invalid source type errors

Event Timeline

kostajh created this task.Jul 7 2022, 10:04 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 7 2022, 10:04 AM

kostajh claimed this task.Jul 7 2022, 10:05 AM

kostajh triaged this task as High priority.

kostajh added a parent task: T306032: Adapt GrowthExperiments to new Image Suggestions API.

kostajh moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 811928 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] ServiceImageRecommendationProvider: Don't fail on first validation error

https://gerrit.wikimedia.org/r/811928

gerritbot added a project: Patch-For-Review.Jul 7 2022, 10:10 AM

Change 811935 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] maintenance: Add GetImageSuggestionData script

https://gerrit.wikimedia.org/r/811935

Change 811953 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.19] ServiceImageRecommendationProvider: Don't fail on first validation error

https://gerrit.wikimedia.org/r/811953

Change 811928 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] ServiceImageRecommendationProvider: Don't fail on first validation error

https://gerrit.wikimedia.org/r/811928

Change 811953 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.19] ServiceImageRecommendationProvider: Don't fail on first validation error

https://gerrit.wikimedia.org/r/811953

Change 811956 had a related patch set uploaded (by Urbanecm; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.18] ServiceImageRecommendationProvider: Don't fail on first validation error

https://gerrit.wikimedia.org/r/811956

Mentioned in SAL (#wikimedia-operations) [2022-07-07T13:24:29Z] <urbanecm@deploy1002> Synchronized php-1.39.0-wmf.19/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ServiceImageRecommendationProvider.php: df1393f10f987f7ddb41aea135ca43dcc6372715: ServiceImageRecommendationProvider: Dont fail on first validation error (T312521) (duration: 03m 30s)

Change 811956 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.18] ServiceImageRecommendationProvider: Don't fail on first validation error

https://gerrit.wikimedia.org/r/811956

Mentioned in SAL (#wikimedia-operations) [2022-07-07T13:44:32Z] <urbanecm@deploy1002> Synchronized php-1.39.0-wmf.18/extensions/GrowthExperiments/includes/NewcomerTasks/AddImage/ServiceImageRecommendationProvider.php: 95c38bd0416d2bb14404526bdf8106ef033e77b3: ServiceImageRecommendationProvider: Dont fail on first validation error (T312521) (duration: 03m 24s)