Regression: parameter list navigation can become invisible behind sticky search field
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

None

Authored By

	awight
	Jul 7 2022, 2:00 PM

Description

Initial scenario:

Steps to reproduce:

Scroll down a long parameter list so that some of the parameters are behind the search field.

Use keyboard navigation to shift-tab into the parameters list (from below).

What happens:
The first parameter is highlighted but it will be scrolled to underneath the template header or search field, and is thus invisible.

What should have happened:
The parameter selection field should have been scrolled to show the top of the list below the search field.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Scroll parameter items into view when hidden behind sticky	mediawiki/extensions/VisualEditor	master	+20 -3

Customize query in gerrit

Related Objects

Mentioned In: T312017: Regression: using keyboard cursor or tab keys makes parameter selection disappear.
Mentioned Here: T312850: Regression: do not move the content pane element to top on focus

Event Timeline

awight created this task.Jul 7 2022, 2:00 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 7 2022, 2:00 PM

awight mentioned this in T312017: Regression: using keyboard cursor or tab keys makes parameter selection disappear..Jul 7 2022, 2:01 PM

WMDE-Fisch claimed this task.Jul 11 2022, 5:49 AM

WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-07-06 board.

From my first look at this:

It seems that this was not working for quite some time. At least before our sidebar removal ( tested on master~300 ).
When first I tab into the list, nothing happens.
When I use the arrow keys to move to the next item in the list, there's some scroll, but it's only scrolling to a certain height.
The latter seems to be related to the sticky header/search container size.

Change 812824 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@master] Scroll parameter items into view when navigating with keyboard

https://gerrit.wikimedia.org/r/812824

gerritbot added a project: Patch-For-Review.Jul 11 2022, 9:01 AM

WMDE-Fisch moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2022-07-06 board.Jul 11 2022, 9:04 AM

lilients_WMDE moved this task from Backlog to In sprint on the WMDE-Templates-FocusArea board.Jul 12 2022, 9:03 AM

Wondering if we should make this a scroll to top in the sidebar as well. Because the content pane is scrolled to top and it looks a little bit off, when the sidebar only scrolls into view and the element is at the bottom of the screen.

Peek 2022-07-12 12-11.gif (928×1 px, 1 MB)

Update: Thinking and talking about this, the issue seems that the content pane is scrolling to top. I created a bug report: T312850. Scrolling the sidebar to top might still be a good idea. Will add this as a question to the epic.

Change 812824 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Scroll parameter items into view when hidden behind sticky

https://gerrit.wikimedia.org/r/812824

awight moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2022-07-06 board.Jul 12 2022, 11:20 AM

Maintenance_bot removed a project: Patch-For-Review.Jul 12 2022, 11:30 AM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 12 2022, 12:00 PM

WMDE-Fisch set the point value for this task to 3.Jul 12 2022, 12:05 PM

WMDE-Fisch changed the point value for this task from 3 to 2.

VPuffetMichel moved this task from To Triage to Triaged on the VisualEditor board.Jul 18 2022, 4:55 PM

Works a bit better, but has two issues:

Keyboard navigate to the last parameter. Press the down arrow, wrapping around to the first parameter. This will be scrolled to beneath the sticky header.
When the number of parameters is fewer, we might not have a search field or the "hide unused" button. In this case the scrolling uses a fixed offset which is incorrect, and scrolled parameters appear lower than the sticky header.

thiemowmde added a project: Regression.Jul 19 2022, 2:08 PM

thiemowmde subscribed.

This is fixed on master with the current changes to scroll to highlighted parameters while respecting the sticky header height.

Regression: parameter list navigation can become invisible behind sticky search fieldClosed, ResolvedPublic2 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

Regression: parameter list navigation can become invisible behind sticky search field
Closed, ResolvedPublic2 Estimated Story Points
Actions