Page MenuHomePhabricator
Create Task
Maniphest T312561

🟥️ Create RemoveItemStatementRouteHandler
Closed, ResolvedPublic
Actions

Description

Create route handler for the DELETE /entries/items/{item_id}/statements/{statement_id} route
Same as T312551 but with additional error cases:

  • 400 for invalid item_id
  • 404 for item_id not found

Details

SubjectRepoBranchLines +/-
REST: Add missing RemoveItemStatement middlewaremediawiki/extensions/Wikibasemaster+20 -0
REST: Create RemoveItemStatementRouteHandlermediawiki/extensions/Wikibasemaster+429 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ollie.Shotton_WMDE created this task.Jul 7 2022, 3:16 PM
Silvan_WMDE claimed this task.Jul 26 2022, 8:47 AM
Silvan_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 10) board.
WMDE-leszek edited projects, added Wikibase Product Platform (v1) (Sprint 11); removed Wikibase Product Platform (v1) (Sprint 10).Jul 27 2022, 9:19 AM
WMDE-leszek moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 11) board.Jul 27 2022, 9:19 AM
gerritbot added a comment.Jul 27 2022, 2:52 PM

Change 817792 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] REST: Create RemoveItemStatementRouteHandler

https://gerrit.wikimedia.org/r/817792

gerritbot added a project: Patch-For-Review.Jul 27 2022, 2:52 PM
Silvan_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 11) board.Jul 27 2022, 6:46 PM
Ollie.Shotton_WMDE moved this task from Peer Review to Doing on the Wikibase Product Platform (v1) (Sprint 11) board.Jul 29 2022, 5:12 PM

817792 +2ed
Precondition middleware is missing but assuming that will be handled in another patch. =)

gerritbot added a comment.Jul 29 2022, 5:25 PM

Change 817792 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Create RemoveItemStatementRouteHandler

https://gerrit.wikimedia.org/r/817792

Maintenance_bot removed a project: Patch-For-Review.Jul 29 2022, 5:30 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.23; 2022-08-01).Jul 29 2022, 6:00 PM
Silvan_WMDE moved this task from Doing to Done on the Wikibase Product Platform (v1) (Sprint 11) board.Aug 2 2022, 8:23 AM
gerritbot added a comment.Aug 5 2022, 1:11 PM

Change 820735 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Add missing RemoveItemStatement middleware

https://gerrit.wikimedia.org/r/820735

gerritbot added a project: Patch-For-Review.Aug 5 2022, 1:11 PM
gerritbot added a comment.Aug 8 2022, 9:06 AM

Change 820735 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Add missing RemoveItemStatement middleware

https://gerrit.wikimedia.org/r/820735

Maintenance_bot removed a project: Patch-For-Review.Aug 8 2022, 9:30 AM
ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.25; 2022-08-15); removed MW-1.39-notes (1.39.0-wmf.23; 2022-08-01).Aug 8 2022, 10:00 AM
Aklapper closed this task as Resolved.Oct 10 2022, 9:55 AM

@Silvan_WMDE: Assuming this task is resolved. Thus setting resolved task status. Please reopen and add an active project tag if that is not the case. Thanks.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits