Page MenuHomePhabricator
Create Task
Maniphest T312589

Graph is storing a stdClass not a JsonDeserializable
Closed, DeclinedPublicPRODUCTION ERROR
Actions

Description

This seems to sneak past the checks added in 09c14b9dd0cc57594d7f4f5aebacb9151c69eb8c but can cause subtle bugs: ParserOutput::getExtensionData will return a stdClass on the first parser, but when the ParserOutput is fetched from cache (subsequent page visits) the value will be unserialized as an array instead of a class and so the return type of getExtensionData will be different.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
JsonCodec: add CycleDetector to detect cyclic referencesC. Scott Ananianmediawiki/coremaster+505 -94
Convert deprecated JsonDeserializable to JsonCodecableC. Scott Ananianmediawiki/extensions/GrowthExperimentsmaster+162 -146
Convert deprecated JsonDeserializable to JsonCodecableC. Scott Ananianmediawiki/extensions/Translatemaster+30 -20
Fix broken deserialization from page propertiesCicalesemediawiki/extensions/TitleIconREL1_39+4 -1
[WIP] Do not double-unserializeSeb35mediawiki/extensions/TitleIconmaster+0 -1
Fix broken deserialization from page propertiesThiemo Kreuz (WMDE)mediawiki/extensions/TitleIconmaster+4 -1
json: Dont try to deserialize actual user-land instancesThiemo Kreuz (WMDE)mediawiki/coremaster+15 -2
JsonCodec: fix en/decoding of nested objects and stdClass objectsC. Scott Ananianmediawiki/coremaster+152 -28
Bump parsoid to 0.17.0-a11Arlolramediawiki/vendormaster+444 -148
TOCData: workaround for non-recursive JsonCodecSubramanya Sastrymediawiki/services/parsoidmaster+9 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

cscott created this task.Jul 7 2022, 7:59 PM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptJul 7 2022, 7:59 PM
cscott mentioned this in T312242: Graph extension: Error: Cannot use object of type stdClass as array.Jul 7 2022, 8:11 PM
gerritbot added a comment.Jul 7 2022, 8:34 PM

Change 812076 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] WIP: ensure that JsonCodec restores stdClass instances as objects not arrays

https://gerrit.wikimedia.org/r/812076

gerritbot added a project: Patch-For-Review.Jul 7 2022, 8:34 PM
cscott added a comment.Jul 7 2022, 8:34 PM

An alternative (see https://gerrit.wikimedia.org/r/c/mediawiki/core/+/812076) is to fix JsonCodec in core to ensure that stdClass objects are unserialized faithfully (as opposed to as arrays).

gerritbot added a comment.Jul 29 2022, 2:51 PM

Change 818478 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] JsonCodec: add CycleDetector to detect cyclic references

https://gerrit.wikimedia.org/r/818478

Krinkle moved this task from Untriaged to Jul 2022 on the Wikimedia-production-error board.Jul 29 2022, 11:03 PM
gerritbot added a comment.Jan 12 2023, 9:42 PM

Change 879136 had a related patch set uploaded (by C. Scott Ananian; author: Subramanya Sastry):

[mediawiki/services/parsoid@master] TOCData: workaround for non-recursive JsonCodec

https://gerrit.wikimedia.org/r/879136

gerritbot added a comment.Jan 13 2023, 9:33 PM

Change 879136 merged by jenkins-bot:

[mediawiki/services/parsoid@master] TOCData: workaround for non-recursive JsonCodec

https://gerrit.wikimedia.org/r/879136

gerritbot added a comment.Jan 16 2023, 5:10 PM

Change 880501 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a11

https://gerrit.wikimedia.org/r/880501

gerritbot added a comment.Jan 16 2023, 5:48 PM

Change 880501 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a11

https://gerrit.wikimedia.org/r/880501

gerritbot added a comment.Jan 19 2023, 8:50 AM

Change 812076 merged by jenkins-bot:

[mediawiki/core@master] JsonCodec: fix en/decoding of nested objects and stdClass objects

https://gerrit.wikimedia.org/r/812076

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.20; 2023-01-23).Jan 19 2023, 9:00 AM
Seb35 subscribed.EditedJan 21 2023, 10:55 PM

The extension TitleIcon has a wrong unserialization since 96e4f5d8402 (more exactly the class MediaWiki\Extension\TitleIcon\Icon): see for instance the patch I am preparing, but the failing tests are independent of the patch and fail exactly when MediaWiki has 96e4f5d8402.

For now I fail to understand if something should be changed to adapt the extension or if there is an issue somewhere.

gerritbot added a comment.Jan 21 2023, 11:22 PM

Change 882192 had a related patch set uploaded (by Seb35; author: Seb35):

[mediawiki/extensions/TitleIcon@master] [WIP] Do not double-unserialize

https://gerrit.wikimedia.org/r/882192

Seb35 added a comment.Jan 21 2023, 11:32 PM

I remarked there are two unserializations in IconManager, and removing the internal unserialization seems to fix the failing tests.

I’m not very comfortable since I don’t know well the extension, neither the change in the unserialization (an advice from you @cscott would be appreciated), and the logic about TitleIcon’s version versus MediaWiki’s version: if it is correct not do do the internal unserialization in MW 1.40+, either the extension must be marked as 1.40+ in extension.json either a more complex logic must be implemented.

gerritbot added a comment.Jan 26 2023, 1:08 PM

Change 883930 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/core@master] json: Dont try to deserialize actual user-land instances

https://gerrit.wikimedia.org/r/883930

gerritbot added a comment.Jan 27 2023, 4:28 PM

Change 883930 merged by jenkins-bot:

[mediawiki/core@master] json: Dont try to deserialize actual user-land instances

https://gerrit.wikimedia.org/r/883930

ReleaseTaggerBot edited projects, added: MW-1.40-notes (1.40.0-wmf.21; 2023-01-30); removed: MW-1.40-notes (1.40.0-wmf.20; 2023-01-23).Jan 27 2023, 5:00 PM
gerritbot added a comment.Feb 2 2023, 8:00 AM

Change 883858 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/TitleIcon@master] Fix broken deserialization from page properties

https://gerrit.wikimedia.org/r/883858

gerritbot added a comment.Feb 2 2023, 2:39 PM

Change 883858 merged by jenkins-bot:

[mediawiki/extensions/TitleIcon@master] Fix broken deserialization from page properties

https://gerrit.wikimedia.org/r/883858

gerritbot added a comment.Feb 26 2023, 2:34 PM

Change 882192 abandoned by Seb35:

[mediawiki/extensions/TitleIcon@master] [WIP] Do not double-unserialize

Reason:

Already merged in I969d8c49106202d9eb3c59f3b4e35c3c89d4c0dd in a better form

https://gerrit.wikimedia.org/r/882192

• JMcLeod_WMF unsubscribed.Mar 30 2023, 1:28 PM
Iniquity moved this task from Backlog to To verify post rewrite on the MediaWiki-extensions-Graph board.Apr 7 2023, 12:50 PM
Pppery edited projects, added: Patch-Needs-Improvement; removed: Patch-For-Review.Apr 9 2023, 7:29 PM
TheDJ subscribed.Apr 19 2023, 9:24 AM

@cscott Anything left to do on this ticket ? Its not entirely clear to me from the task and the tickets.

Jdlrobson moved this task from To verify post rewrite to Code health on the MediaWiki-extensions-Graph board.Apr 25 2023, 10:01 PM
Jdlrobson triaged this task as Low priority.Apr 25 2023, 10:28 PM
gerritbot added a comment.Jun 23 2023, 1:15 PM

Change 932276 had a related patch set uploaded (by Cicalese; author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/TitleIcon@REL1_39] Fix broken deserialization from page properties

https://gerrit.wikimedia.org/r/932276

gerritbot added a project: Patch-For-Review.Jun 23 2023, 1:15 PM
Restricted Application removed a project: Patch-Needs-Improvement. · View Herald TranscriptJun 23 2023, 1:15 PM
gerritbot added a comment.Jun 23 2023, 1:19 PM

Change 932276 merged by jenkins-bot:

[mediawiki/extensions/TitleIcon@REL1_39] Fix broken deserialization from page properties

https://gerrit.wikimedia.org/r/932276

Pppery edited projects, added: Patch-Needs-Improvement; removed: Patch-For-Review.Jun 23 2023, 3:41 PM
cscott closed subtask T313452: Fix JsonCodec to unserialize stdClass objects faithfully as Resolved.May 1 2024, 5:53 PM
Umherirrender renamed this task from Graph is storing a stdClass not a JsonUnserializable to Graph is storing a stdClass not a JsonDeserializable.Jul 10 2024, 7:44 PM
Aklapper removed cscott as the assignee of this task.Nov 19 2024, 6:05 PM

@cscott: Removing task assignee as this open task has been assigned for more than two years - See the email sent to task assignee on October 11th.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome! :)
If this task has been resolved in the meantime, or should not be worked on by anybody ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!

gerritbot added a comment.Sep 5 2025, 1:22 PM

Change #1185091 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/GrowthExperiments@master] Convert deprecated JsonDeserializable to JsonCodecable

https://gerrit.wikimedia.org/r/1185091

Restricted Application changed the subtype of this task from "Task" to "Production Error". · View Herald TranscriptSep 5 2025, 1:22 PM
gerritbot added a project: Patch-For-Review.Sep 5 2025, 1:22 PM
Restricted Application removed a project: Patch-Needs-Improvement. · View Herald TranscriptSep 5 2025, 1:22 PM
gerritbot added a comment.Sep 5 2025, 3:10 PM

Change #1185113 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/Translate@master] Convert deprecated JsonDeserializable to JsonCodecable

https://gerrit.wikimedia.org/r/1185113

gerritbot added a comment.Sep 10 2025, 2:23 PM

Change #1185113 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Convert deprecated JsonDeserializable to JsonCodecable

https://gerrit.wikimedia.org/r/1185113

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.19; 2025-09-16).Sep 10 2025, 3:00 PM
gerritbot added a comment.Sep 18 2025, 1:16 PM

Change #1185091 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Convert deprecated JsonDeserializable to JsonCodecable

https://gerrit.wikimedia.org/r/1185091

ReleaseTaggerBot edited projects, added: MW-1.45-notes (1.45.0-wmf.20; 2025-09-23); removed: MW-1.45-notes (1.45.0-wmf.19; 2025-09-16).Sep 18 2025, 2:01 PM
Bugreporter closed this task as Declined.Sep 25 2025, 8:46 AM
gerritbot added a comment.Mar 30 2026, 1:20 PM

Change #818478 abandoned by Hashar:

[mediawiki/core@master] JsonCodec: add CycleDetector to detect cyclic references

https://gerrit.wikimedia.org/r/818478

gerritbot added a comment.Mar 30 2026, 11:35 PM

Change #818478 restored by Thcipriani:

[mediawiki/core@master] JsonCodec: add CycleDetector to detect cyclic references

https://gerrit.wikimedia.org/r/818478

Pppery edited projects, added: Patch-Needs-Improvement; removed: Patch-For-Review.Mar 31 2026, 1:03 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits