Maniphest T312644

Regression: bottom margin is lost when filtering parameters
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	awight
	Jul 8 2022, 12:59 PM

Tags

Referenced Files

	F35311973: image.png
	Jul 8 2022, 12:59 PM

	F35311971: image.png
	Jul 8 2022, 12:59 PM

Subscribers

Description

Due to our use of :last-child, when parameters are filtered the bottom margin can be incorrect.

Normal:

image.png (137×256 px, 3 KB)

Filtered:

image.png (172×259 px, 4 KB)

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Streamline button margin calculation for outline parts	mediawiki/extensions/VisualEditor	master	+7 -13

Customize query in gerrit

Event Timeline

awight created this task.Jul 8 2022, 12:59 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 8 2022, 12:59 PM

awight updated the task description. (Show Details)Jul 8 2022, 12:59 PM

thiemowmde moved this task from Incoming to Priority backlog on the WMDE-TechWish-Maintenance board.Jul 12 2022, 9:13 AM

thiemowmde moved this task from Priority backlog to Backlog on the WMDE-TechWish-Maintenance board.

Lena_WMDE moved this task from Backlog to Ready for pickup on the WMDE-Templates-FocusArea board.Jul 13 2022, 10:28 AM

thiemowmde added a project: Regression.Jul 20 2022, 8:36 AM

lilients_WMDE assigned this task to WMDE-Fisch.Aug 2 2022, 12:57 PM

lilients_WMDE added projects: WMDE-TechWish-Sprint-2022-07-20, Unplanned-Sprint-Work.

lilients_WMDE set the point value for this task to 2.

lilients_WMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-07-20 board.

lilients_WMDE moved this task from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.

Change 819584 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@master] Streamline button margin calculation for outline parts

https://gerrit.wikimedia.org/r/819584

gerritbot added a project: Patch-For-Review.Aug 2 2022, 1:12 PM

WMDE-Fisch moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2022-07-20 board.Aug 2 2022, 1:14 PM

WMDE-Fisch added a project: WMDE-TechWish-Sprint-2022-08-03.Aug 3 2022, 8:07 AM

WMDE-Fisch moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2022-08-03 board.Aug 3 2022, 8:12 AM

lilients_WMDE removed a project: Unplanned-Sprint-Work.Aug 3 2022, 1:32 PM

Change 819584 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Streamline button margin calculation for outline parts

https://gerrit.wikimedia.org/r/819584

WMDE-Fisch moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2022-08-03 board.Aug 4 2022, 1:23 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 4 2022, 1:30 PM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 4 2022, 2:00 PM

VPuffetMichel moved this task from To Triage to Triaged on the VisualEditor board.Aug 11 2022, 3:31 PM

WMDE-Fisch closed this task as Resolved.Aug 16 2022, 9:54 AM