Page MenuHomePhabricator
Create Task
Maniphest T312646

Automatically update participant list on event page after new registration
Closed, ResolvedPublic
Actions

Assigned To
Daimona
Authored By
ifried
Jul 8 2022, 1:34 PM
Tags
Referenced Files
F35456389: Screen Recording 2022-08-15 at 1.51.14 PM.mov-6182BF8E-88F8-4818-8F7D-143542A05A42.gif
Aug 15 2022, 6:54 PM
F35312029: Screen Shot 2022-07-08 at 9.31.50 AM.png
Jul 8 2022, 1:34 PM
F35312028: Screen Shot 2022-07-08 at 9.31.40 AM.png
Jul 8 2022, 1:34 PM
Subscribers
Aklapper
Daimona
ifried
vaughnwalters

Description

As a campaign participant, I want to see my username automatically added and the number of participants to go up by 1 when I register for an event, so that I can know that I am fully registered without any confusion or need to refresh the page.

Acceptance Criteria:

  • When a participant registers for an event on the event page, the registration header and the 'more details' display should:
    • Automatically update to show the new number of participants (it should go up by 1) in the registration header and 'more details' section
    • Automatically display the username of the participant who registered in the 'more details' section
  • Note: It is acceptable behavior for the page to be refreshed in order for these changes to be displayed to the user for V1. We may want to change this behavior in later versions, but it is fine for V1.

Visual examples of current behavior (see that person is attending, but 0 participants are displayed):

Screen Shot 2022-07-08 at 9.31.40 AM.png (1×2 px, 600 KB)

Screen Shot 2022-07-08 at 9.31.50 AM.png (1×2 px, 465 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Improve behaviour of registration header and dialogmediawiki/extensions/CampaignEventsmaster+161 -95
Customize query in gerrit

Related Objects

Event Timeline

ifried created this task.Jul 8 2022, 1:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 8 2022, 1:34 PM
ldelench_wmf triaged this task as High priority.Jul 20 2022, 1:39 AM
ldelench_wmf edited projects, added Campaign-Registration, Connection-Team (Campaign-Tools-Sprint-17); removed Connection-Team.
ifried updated the task description. (Show Details)Jul 26 2022, 3:41 PM
Daimona subscribed.Jul 26 2022, 4:42 PM

Noting here for posterity that we will refresh the page when you register so that you always see the latest version of the list. Since the dialog is generated on the PHP side (because of limitations like T21992 and T181684), controlling its behaviour from JS is a bit challenging. There would be many edge cases like:

  • If an event has 40 participants (only 20 are shown) and you register, should we show 21 (you + others) or 20 (you + others - last previous)?
    • If 21: should we still show 21 when you refresh the page or go back to 20?
  • We would need to conditionally hide/show the "view full list" link if the limit of 20 is crossed when you (un)register

All in all, it seems unnecessarily complex to make this work now. Instead, it would be much easier to make it work properly once the dialog logic is moved to the JS side (i.e., when the tasks linked above are fixed).

gerritbot added a comment.Jul 26 2022, 5:18 PM

Change 817313 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Improve behaviour of registration header and dialog

https://gerrit.wikimedia.org/r/817313

gerritbot added a project: Patch-For-Review.Jul 26 2022, 5:18 PM
Daimona moved this task from Ready 🎬 to Review/Feedback 💬 on the Connection-Team (Campaign-Tools-Sprint-17) board.Jul 26 2022, 5:20 PM
Daimona claimed this task.Aug 3 2022, 3:58 PM
gerritbot added a comment.Aug 8 2022, 7:11 PM

Change 817313 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Improve behaviour of registration header and dialog

https://gerrit.wikimedia.org/r/817313

Daimona mentioned this in rUCAMe05d7e369481: Improve behaviour of registration header and dialog.Aug 8 2022, 7:13 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 8 2022, 7:30 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 8 2022, 8:00 PM
Daimona moved this task from Review/Feedback 💬 to QA 🐛 on the Connection-Team (Campaign-Tools-Sprint-17) board.Aug 8 2022, 9:00 PM
ldelench_wmf edited projects, added Connection-Team (Connection-Current-Sprint); removed Connection-Team (Campaign-Tools-Sprint-17).Aug 14 2022, 9:30 PM
ldelench_wmf moved this task from Upcoming / refining 💡 to QA 🐛 on the Connection-Team (Connection-Current-Sprint) board.Aug 14 2022, 9:35 PM
vaughnwalters moved this task from QA 🐛 to Product sign-off 🤘 on the Connection-Team (Connection-Current-Sprint) board.Aug 15 2022, 6:54 PM
vaughnwalters subscribed.

Registration header and more details display are correctly updated when a participant registers

Screen Recording 2022-08-15 at 1.51.14 PM.mov-6182BF8E-88F8-4818-8F7D-143542A05A42.gif (506×720 px, 2 MB)

ifried closed this task as Resolved.Aug 30 2022, 4:48 PM
ifried moved this task from Product sign-off 🤘 to Done 🏁 on the Connection-Team (Connection-Current-Sprint) board.

This is now working as expected (as shown in video example shared above). I'm marking this as Done.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits