Page MenuHomePhabricator

[Refactor] Differ between setting and highlighting a parameter
Closed, ResolvedPublic3 Estimated Story Points

Description

Issue
We used the select state of OOUI SelectWidget items for the checkbox state (checked or not) and now cannot use it for its original purpose, like displaying the selection in addition to the cursor.

Possible solution
Give select state back and move checkedness out of select widget.
Could be maintained by the MWTransclusionOutlineParameterWidget.
Needs to be accessible: a multiselect will read its selected items aloud.

Advantages
Would make it possible that mouse hover and key movement are the same interaction (like it is now in OOUI)
Would prevent us from re-designing small interactions that are already working in OOUI
Gives a conceptual distinction between selected, checked, and highlighted.

Risks
Could be difficult. SelectWidget is 500 lines long.
Introducing more regressions.

Event Timeline

Change 812435 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@master] Differ between setting and highlighting a parameter

https://gerrit.wikimedia.org/r/812435

lilients_WMDE renamed this task from Investigate different implementation of checkboxes in SelectWidget to Differ between setting and highlighting a parameter.Jul 11 2022, 10:51 AM

Change 812435 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Differ between setting and highlighting a parameter

https://gerrit.wikimedia.org/r/812435

This patch causes a regression T312856, we might consider reverting until it can be fixed.

awight renamed this task from Differ between setting and highlighting a parameter to [Refactor]Differ between setting and highlighting a parameter.Jul 19 2022, 10:34 AM
awight renamed this task from [Refactor]Differ between setting and highlighting a parameter to [Refactor] Differ between setting and highlighting a parameter.

Change 815909 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Tab to first template parameter in list, not to the selection

https://gerrit.wikimedia.org/r/815909

Change 815909 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Tab to first template parameter in list, not to the selection

https://gerrit.wikimedia.org/r/815909