Page MenuHomePhabricator
Create Task
Maniphest T312668

Update CheckUser to use the new HookContainer/HookRunner system
Closed, ResolvedPublic
Actions

Description

Implement the Hook system added in MediaWiki 1.35 in the extensions, see Hooks.md for documentation.

  • Use hook handlers for core hooks.
  • Use hook handlers for UserMerge hook

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Create UserMergeHandler for ::onUserMergeAccountFields handlermediawiki/extensions/CheckUsermaster+65 -40
Zuul: Add UserMerge extension to CheckUser extension dependency listintegration/configmaster+3 -2
Convert last few CheckUser provided hooks to the HookRunner systemmediawiki/extensions/CheckUsermaster+98 -10
Hooks: Merge RecentChange_save handlersmediawiki/extensions/CheckUsermaster+15 -14
Migrate most MW Core hooks to HookHandlermediawiki/extensions/CheckUsermaster+63 -60
Customize query in gerrit

Related Objects
Search...

Event Timeline

Zabe created this task.Jul 8 2022, 6:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 8 2022, 6:52 PM
gerritbot added a comment.Aug 15 2022, 1:14 AM

Change 822746 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/CheckUser@master] Migrate most MW Core hooks to HookHandler

https://gerrit.wikimedia.org/r/822746

gerritbot added a project: Patch-For-Review.Aug 15 2022, 1:14 AM
gerritbot added a comment.Aug 15 2022, 1:30 AM

Change 822747 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/CheckUser@master] Hooks: Merge RecentChange_save handlers

https://gerrit.wikimedia.org/r/822747

Zabe removed Zabe as the assignee of this task.Aug 15 2022, 7:57 AM
gerritbot added a comment.Aug 15 2022, 1:12 PM

Change 822746 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Migrate most MW Core hooks to HookHandler

https://gerrit.wikimedia.org/r/822746

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 15 2022, 2:00 PM
gerritbot added a comment.Aug 17 2022, 3:03 PM

Change 822747 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Hooks: Merge RecentChange_save handlers

https://gerrit.wikimedia.org/r/822747

Maintenance_bot removed a project: Patch-For-Review.Aug 17 2022, 3:30 PM
ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.26; 2022-08-22); removed MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 17 2022, 4:00 PM
gerritbot added a comment.Dec 26 2022, 11:20 PM

Change 871910 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Convert last few CheckUser provided hooks to the HookRunner system

https://gerrit.wikimedia.org/r/871910

gerritbot added a project: Patch-For-Review.Dec 26 2022, 11:20 PM
Dreamy_Jazz claimed this task.Dec 26 2022, 11:20 PM
Dreamy_Jazz triaged this task as Low priority.
Dreamy_Jazz moved this task from Inbox to Patches for review on the CheckUser board.Dec 28 2022, 11:19 PM
gerritbot added a comment.Jan 2 2023, 1:04 AM

Change 871910 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Convert last few CheckUser provided hooks to the HookRunner system

https://gerrit.wikimedia.org/r/871910

Dreamy_Jazz moved this task from Patches for review to Inbox on the CheckUser board.Jan 2 2023, 1:06 AM
Dreamy_Jazz removed Dreamy_Jazz as the assignee of this task.Jan 2 2023, 1:17 AM
Dreamy_Jazz subscribed.

Migrating the code that hooks on to non-MW core hooks that are also not in the extension gate tests needs to be considered. May come back to try this again, but unsure of a nice solution right now.

Maintenance_bot removed a project: Patch-For-Review.Jan 2 2023, 1:29 AM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Jan 2 2023, 2:00 AM
Dreamy_Jazz added a subtask: T328334: Split Hooks.php into seperate HookHandler files.Jan 30 2023, 4:46 PM
Umherirrender mentioned this in T338450: Update StructuredDiscussions (Flow) to use the new HookContainer/HookRunner system.Sep 16 2023, 10:16 PM
Umherirrender updated the task description. (Show Details)Sep 16 2023, 10:24 PM
Umherirrender mentioned this in T346523: Update WikimediaMessages to use the new HookContainer/HookRunner system.Sep 16 2023, 11:36 PM
gerritbot added a comment.Sep 17 2023, 8:38 PM

Change 958062 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[integration/config@master] [WIP] Add UserMerge to CheckUser phan dependencies

https://gerrit.wikimedia.org/r/958062

gerritbot added a project: Patch-For-Review.Sep 17 2023, 8:38 PM
Dreamy_Jazz removed a subtask: T328334: Split Hooks.php into seperate HookHandler files.Sep 17 2023, 8:44 PM
gerritbot added a comment.Sep 17 2023, 9:28 PM

Change 958064 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Create UserMergeHandler for UserMerge AccountFieldsHook handler

https://gerrit.wikimedia.org/r/958064

Dreamy_Jazz claimed this task.Sep 17 2023, 9:49 PM
gerritbot added a comment.Sep 19 2023, 9:41 AM

Change 958062 merged by jenkins-bot:

[integration/config@master] Zuul: Add UserMerge extension to CheckUser extension dependency list

https://gerrit.wikimedia.org/r/958062

Dreamy_Jazz added a project: Anti-Harassment-Team (AHaT Sprint 32 - Baseball Cap).Sep 29 2023, 8:30 PM
Dreamy_Jazz moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment-Team (AHaT Sprint 32 - Baseball Cap) board.
gerritbot added a comment.Sep 29 2023, 9:13 PM

Change 958064 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Create UserMergeHandler for ::onUserMergeAccountFields handler

https://gerrit.wikimedia.org/r/958064

Maintenance_bot removed a project: Patch-For-Review.Sep 29 2023, 9:30 PM
Dreamy_Jazz closed this task as Resolved.Sep 29 2023, 9:52 PM
Dreamy_Jazz removed a project: Anti-Harassment-Team (AHaT Sprint 32 - Baseball Cap).
Dreamy_Jazz updated the task description. (Show Details)
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.29; 2023-10-03).Sep 29 2023, 10:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits