Revisit placement of "Subscribe" / "Unsubscribe" within Topic Containers (desktop)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• ppelberg
	Jul 8 2022, 7:28 PM

Description

In T310914#8030385, @DLynch noted how the current placement of the Subscribe / Unsubscribe affordances within desktop Topic Containers looks a bit off.

This task involves the work with reviewing the initial implementation (T310914) and deciding what – if anything – we'll do to address the Observations documented below.

Observations

ID	Observation	Screenshot
1.	Subscribe affordance's distance from section heading looks a bit off

Mockup(s)

If we decide to adjust where the Subscribe affordance is shown within the Topic Containers on desktop, then this section will contain mockup(s) showing where the the Subscribe affordance should be moved to.

Open questions

1. What – if any – adjustments will we make to where the Subscribe affordance is shown within the Topic Containers on desktop?

Done

Answers to all Open questions are documented
Mockup(s) are included in the Mockup(s) section above and implemented

Details

	Subject	Repo	Branch	Lines +/-
	Move subscribe button up on desktop	mediawiki/extensions/DiscussionTools	master	+418 -388

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T276497 Scale DiscussionTools to all projects
Open	None	T310959 Scale Usability Improvements to all projects
Open	None	T319146 [Release Ticket] Offer Usability Improvements as default-on feature at all projects (desktop)
Resolved	• ppelberg	T302547 [Usability Improvements] Deploy as Beta Feature at all wikis (desktop)
Resolved	• ppelberg	T312671 [Release Ticket] Deploy Topic Containers (desktop) as Beta Feature (Phase 1 wikis)
Resolved	nayoub	T312674 Revisit placement of "Subscribe" / "Unsubscribe" within Topic Containers (desktop)

Event Timeline

• ppelberg created this task.Jul 8 2022, 7:28 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 8 2022, 7:28 PM

• ppelberg moved this task from Backlog to Existing Feature Improvements on the DiscussionTools board.Jul 8 2022, 7:28 PM

• ppelberg moved this task from Untriaged to This Fiscal Year on the Editing-team board.

• ppelberg added a parent task: T312671: [Release Ticket] Deploy Topic Containers (desktop) as Beta Feature (Phase 1 wikis).Jul 8 2022, 7:39 PM

• ppelberg mentioned this in T310914: Implement Topic Container design adjustments (desktop + mobile).

nayoub subscribed.Jul 19 2022, 10:07 PM

• ppelberg edited projects, added Editing-team (Kanban Board); removed Editing-team.Jul 19 2022, 10:07 PM

• ppelberg moved this task from Incoming to Ready to Be Worked On on the Editing-team (Kanban Board) board.Jul 19 2022, 10:47 PM

• ppelberg assigned this task to nayoub.Jul 19 2022, 10:49 PM

• ppelberg updated the task description. (Show Details)

Change 815712 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Move subscribe button up on desktop

https://gerrit.wikimedia.org/r/815712

gerritbot added a project: Patch-For-Review.Jul 20 2022, 1:07 PM

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/286c9d8649/w

https://patchdemo.wmflabs.org/wikis/286c9d8649/w/index.php?title=Special:UserLogin&returnto=Talk%3ADiscussionTools&returntoquery=mobileaction%3Dtoggle_view_desktop

This doesn’t look nice IMO.

Maybe put the headline before the subscribe link in the DOM and float both? It would cause the same behavior when the headline is shorter than one line, and push it to the next line if it’s longer than that. Since there’s no that big white space anyway if the headline reaches the right margin, I hope it won’t embarrass @DLynch either. I thought about something along the lines

<h2 class="ext-discussiontools-init-section">
	<div style="float:left">
		<span class="mw-headline">...</span>
		<span class="mw-editsection">...</span>
	</div>
	<span class="ext-discussiontools-init-section-subscribeButton" style="float:right">...</span>
	<div class="ext-discussiontools-init-section-bar" style="clear:left">...</div>
</h2>

In T312674#8091780, @Tacsipacsi wrote:

This doesn’t look nice IMO.

I think all that's missing here is a left margin on the subscribe button and a tweak to the vertical alignment:

Esanders attached a referenced file: F35327015: image.png. (Show Details)Jul 20 2022, 8:56 PM

• ppelberg added a project: Goal.Jul 26 2022, 4:34 PM

• ppelberg mentioned this in T313872: Evolve how section edit links are presented to be more visually consistent with rest of Topic Container.Jul 26 2022, 10:57 PM

Change 815712 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Move subscribe button up on desktop

https://gerrit.wikimedia.org/r/815712

Maintenance_bot removed a project: Patch-For-Review.Jul 27 2022, 2:30 PM

matmarex moved this task from Ready to Be Worked On to QA on the Editing-team (Kanban Board) board.Jul 27 2022, 2:44 PM

matmarex added a project: Editing QA.

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.23; 2022-08-01).Jul 27 2022, 3:00 PM

Ryasmeen edited projects, added Verified; removed Editing QA.Jul 28 2022, 11:58 PM

Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Jul 29 2022, 12:02 AM

While I think what @Esanders implemented aligns with what @nayoub had in mind, I'm assigning this over to Nico to verify this to be true.

Thanks @ppelberg! Yes this looks good to me, we'll have to see in a later stage if & how to homogenize with other parts of the UI as reflected in T313872.

In T312674#8114067, @nayoub wrote:

Thanks @ppelberg! Yes this looks good to me, we'll have to see in a later stage if & how to homogenize with other parts of the UI as reflected in T313872.

Excellent. Thank you for confirming, @nayoub.

• ppelberg closed this task as Resolved.Jul 29 2022, 9:11 PM

Jack_who_built_the_house subscribed.Aug 6 2022, 11:56 PM

matmarex mentioned this in T316147: Subscribe button is misaligned.Aug 24 2022, 9:35 PM

Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/286c9d8649/w/~~

	F35326838: Screenshot 2022-07-20 at 18-18-12 Talk DiscussionTools - Patch demo (815712,1).png
	Jul 20 2022, 4:35 PM

	F35312292: Screen Shot 2022-07-08 at 12.22.12 PM.png
	Jul 8 2022, 7:28 PM

Revisit placement of "Subscribe" / "Unsubscribe" within Topic Containers (desktop)Closed, ResolvedPublicActions