MMV dialog hides notifications (mw.notify)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Jul 11 2022, 2:32 PM

Description

Notifications should appear in the top layer, above even modal dialogs, like they do with OOUI dialogs. However they appear below MMV dialogs. This was observed in T312770 where the "Copied/Not copied" notification is hidden.

Open an image with MMV
Trigger a notification by opening the share/reuse module and clicking the copy button
Expected: You see a notification

Observed: You don't see a notification

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Restore z-index of mw-notification-area	mediawiki/skins/Vector	master	+0 -6
	MMV lightbox: Allow notifications to appear on top of the lightbox	mediawiki/extensions/MultimediaViewer	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T312783: [Unplanned] Notifications (mw.notify) are appearing below OOUI modals
Mentioned Here: T312783: [Unplanned] Notifications (mw.notify) are appearing below OOUI modals
T312770: "Copy" button in MMV share/embed widget not working

Event Timeline

Esanders created this task.Jul 11 2022, 2:32 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 11 2022, 2:32 PM

T312783 is partially responsible as it sets the z-index of the notifications to lower than that of MMV, but also MMV hides everything that isn't it with the body.mw-mmv-lightbox-open > * selector.

Esanders updated the task description. (Show Details)Jul 11 2022, 3:02 PM

Change 812885 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/MultimediaViewer@master] MMV lightbox: Allow notifications to appear on top of the lightbox

https://gerrit.wikimedia.org/r/812885

gerritbot added a project: Patch-For-Review.Jul 11 2022, 3:08 PM

Change 812890 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/skins/Vector@master] Restore z-index of mw-notification-area

https://gerrit.wikimedia.org/r/812890

Change 812885 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] MMV lightbox: Allow notifications to appear on top of the lightbox

https://gerrit.wikimedia.org/r/812885

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 12 2022, 7:02 AM