Page MenuHomePhabricator

A line appears above the page title in dark mode
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

Open this link (a preview of the dark mode gadget)

What happens?:
A line appears above the page title. "It is because .mw-body has a 1px transparent border-top property which is causing the line to appear on the dark mode" --@Terasail

What should have happened instead?:
The line shouldn't appear (?)

obraz.png (209×978 px, 65 KB)

Additional information
I'm not sure why, but when I'm logged in, when I try to reproduce, instead of the line, I can see a box with four borders. However, when I'm logged out, the line appears:

obraz.png (1×1 px, 195 KB)
obraz.png (1×1 px, 170 KB)

Event Timeline

This is just because https://en.wikipedia.org/wiki/MediaWiki:Gadget-dark-mode.css overrides (Line 99/103) the transparent color of the border which in this case creates a top line. But the color change is needed for legacy vector.

@Jdlrobson There are two options I see:

  • When looking at legacy Vector, I don't see why it needs that transparent border. Remove it or make it white.
  • Make an exception in dark mode CSS for that border

The transparent border is there to prevent a margin collapse

i don't seem to have permission to edit the CSS (link). @Volker_E @MusikAnimal can one of you update this to make the border transparent in dark mode?