Page MenuHomePhabricator
Create Task
Maniphest T312856

Regression: impossible to unselect a parameter when the list is scrolled
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  • Open the template dialog with a template having lots of parameters:

image.png (587×269 px, 27 KB)

  • Scroll the parameter list down until the top item is off the screen:

image.png (362×291 px, 16 KB)

  • Click a checkbox to remove the parameter (mouse-down only).

What happens:

  • The top parameter in the list is scrolled into view. This makes it impossible to remove the parameter that was clicked.

What should have happened:

  • No scrolling.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Don't call parent on SelectWidget focus eventmediawiki/extensions/VisualEditormaster+1 -2
[WIP] Reuse more built-in mouse handlingmediawiki/extensions/VisualEditormaster+19 -46
Customize query in gerrit

Related Objects

Event Timeline

awight created this task.Jul 12 2022, 1:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 12 2022, 1:27 PM
awight added a project: WMDE-TechWish-Sprint-2022-07-06.Jul 12 2022, 1:27 PM

Moving into the sprint as it seems to be a high-impact bug.

awight mentioned this in T312647: [Refactor] Differ between setting and highlighting a parameter.Jul 12 2022, 1:31 PM
awight moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-07-06 board.Jul 12 2022, 1:37 PM
gerritbot added a comment.Jul 12 2022, 1:37 PM

Change 813243 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Let the SelectWidget handle onMouseDown

https://gerrit.wikimedia.org/r/813243

gerritbot added a project: Patch-For-Review.Jul 12 2022, 1:37 PM
awight moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2022-07-06 board.Jul 12 2022, 1:37 PM
Lena_WMDE moved this task from Backlog to In sprint on the WMDE-Templates-FocusArea board.Jul 13 2022, 9:40 AM
gerritbot added a comment.Jul 13 2022, 1:44 PM

Change 813631 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@master] Don't call parent on SelectWidget focus event

https://gerrit.wikimedia.org/r/813631

awight moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2022-07-06 board.Jul 13 2022, 1:59 PM
awight mentioned this in T312924: Regression: click on parameter causing jumping and no check selection (VE template dialog).Jul 13 2022, 2:01 PM
gerritbot added a comment.Jul 13 2022, 2:12 PM

Change 813631 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Don't call parent on SelectWidget focus event

https://gerrit.wikimedia.org/r/813631

gerritbot added a comment.Jul 18 2022, 12:27 PM

Change 813243 abandoned by Awight:

[mediawiki/extensions/VisualEditor@master] [WIP] Reuse more built-in mouse handling

Reason:

won't pursue this

https://gerrit.wikimedia.org/r/813243

Maintenance_bot removed a project: Patch-For-Review.Jul 18 2022, 12:30 PM
awight moved this task from Demo to Done on the WMDE-TechWish-Sprint-2022-07-06 board.Jul 19 2022, 8:45 AM
thiemowmde closed this task as Resolved.Jul 20 2022, 8:10 AM
thiemowmde claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits