| ifried | |
| Jul 12 2022, 2:01 PM |
| F35327006: Screen Shot 2022-07-20 at 3.36.22 PM.png | |
| Jul 20 2022, 9:03 PM |
As an event organizer, I only want event organizers for a particular event to be able to enable registration on an event page, so that registration is only enabled for events where organizers want it enabled.
Acceptance Criteria:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Check if the user created the event page in userCanEnableRegistration | mediawiki/extensions/CampaignEvents | master | +147 -22 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Invalid | None | T312948 v0 Known Bugs to be fixed in v1 | |||
| Resolved | Daimona | T312857 Only the creator of the event page can enable registration [soon after V0 or high priority V1] |
I changed the wording of the AC a bit: the concept of "event organizer" does not exist until a registration is created. In order to know if someone is an organizer for a given event, they'd have to enable registration first. Also, there's no actual concept of "event" in the application. The closest entity that we have is the "event registration" entity.
Change 815296 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[mediawiki/extensions/CampaignEvents@master] Check if the user created the event page in userCanEnableRegistration
Change 815296 merged by jenkins-bot:
[mediawiki/extensions/CampaignEvents@master] Check if the user created the event page in userCanEnableRegistration
This is functioning correctly - The response given in the API and UI is if any user except for the event creator attempts to enable registration is "You are not allowed to enable event registration for the given event page."
One note - if a user navigates to an event that doesn't yet have registration enabled and they are not the creator of the event, there is no notice to let the user know that it has not been enabled and that only the creator of the event can enable that registration. Screenshot below is what any user except for the event creator would see for an event page that hasn't yet had registration enabled. @ifried or @Daimona - do you have any thoughts on this? It is somewhat similar to issue #2 in the note for this ticket about deleting events T312775#8091819,
Thanks for bringing this up, @vaughnwalters! It brings up a great idea/point.
My current thought process is that it's okay to allow organizers to create event pages that have no registration (and to have no indication that they do not have registration enabled). This is because some organizers may not need registration at all or they may want to use a different registration solution than the one we have created. For this reason, it would be confusing and frustrating if there was some public notice that is viewable to all user like "Registration hasn't been enabled yet," when the organizer would have no plans to ever enable it. So, I think that, for now, we can keep the current experience, but we can keep our eyes open for any confusion or clarity requested among user testers around this flow.
On another note, I have tested this, and it is now working as expected, so I will mark it as Done.