NDA tool should treat `~` as a symbol, not a non-Latin character
Open, LowPublic
Actions

Assigned To

None

Authored By

	jrbs
	Jul 12 2022, 7:48 PM

Description

The NDA tool automatically sorts usernames alphabetically, including separating out "non-Latin" from "symbols" (and of course Latin characters). This should be tweaked since ~riley begins with a symbol (as we've defined it on that page), not a non-Latin character.

Event Timeline

jrbs created this task.Jul 12 2022, 7:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 12 2022, 7:48 PM

If I could be pointed to the code base for this software I might even be able to fix this myself :)

https://github.com/samuelguebo/tsbot-nda/pull/2

Merged and deployed lemme know if that fixed it - sorry didn't get the chance to test it live as I no longer have a TS account. Let me know if you have a tool account and I add you as a deployer. Once the PR is merged deploying is usually just ssh'ing and running a shell script that does all the git and kubernetes steps.

In T312898#8073881, @sguebo_WMF wrote:

Merged and deployed lemme know if that fixed it - sorry didn't get the chance to test it live as I no longer have a TS account. Let me know if you have a tool account and I add you as a deployer. Once the PR is merged deploying is usually just ssh'ing and running a shell script that does all the git and kubernetes steps.

I probably do ... I don't remember :) I'll dig into it.,

jrbs moved this task from Backlog to Radar on the Trust-and-Safety board.Aug 19 2022, 11:08 PM

@jrbs was added as a maintainer to the NDA bot, see (https://toolsadmin.wikimedia.org/tools/id/tsbot). Also, the code was moved the Wikimedia's Gitlab instance: https://gitlab.wikimedia.org/repos/security/tsbot-nda

NDA tool should treat `~` as a symbol, not a non-Latin characterOpen, LowPublicActions

Description

Event Timeline

NDA tool should treat `~` as a symbol, not a non-Latin character
Open, LowPublic
Actions