Page MenuHomePhabricator
Create Task
Maniphest T312910

Fix format of timestamps on the participants list on event details page
Closed, ResolvedPublic
Actions

Assigned To
MHorsey-WMF
Authored By
cmelo
Jul 13 2022, 4:39 AM
Tags
Referenced Files
F35531257: Screen Shot 2022-09-23 at 5.04.32 PM.png
Sep 23 2022, 9:05 PM
F35531255: Screen Shot 2022-09-23 at 5.04.10 PM.png
Sep 23 2022, 9:05 PM
F35505966: Screen Recording 2022-09-01 at 3.38.46 PM.gif
Sep 1 2022, 8:53 PM
F35505963: Screen Recording 2022-09-01 at 3.12.39 PM.gif
Sep 1 2022, 8:53 PM
F35505961: Screen Recording 2022-09-01 at 3.07.38 PM.gif
Sep 1 2022, 8:53 PM
F35316140: image8.png
Jul 13 2022, 2:31 PM
Subscribers
Aklapper
cmelo
Daimona
ifried
MHorsey-WMF
vaughnwalters

Description

This is for V1 (not V0).

Acceptance criteria:

  • Documentation of the "List the participants of an event" endpoint should be updated to mention the new field and the format for both fields
  • The date and time shown on the participants list on event details page should be consistently formatted according to user preference. currently, only the first 20 have the correct format:

image8.png (538×346 px, 92 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix format of timestamps on the participants list on event details pagemediawiki/extensions/CampaignEventsmaster+24 -13
Customize query in gerrit

Related Objects
Search...

Event Timeline

cmelo created this task.Jul 13 2022, 4:39 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 13 2022, 4:39 AM
cmelo claimed this task.Jul 13 2022, 4:39 AM
cmelo updated the task description. (Show Details)Jul 13 2022, 2:12 PM
• vyuen renamed this task from Set the date and time shown on the participants list on event details page to be "TS_DB" to Fix format of timestamps on the participants list on event details page [not v0].Jul 13 2022, 2:31 PM
• vyuen triaged this task as Medium priority.
• vyuen updated the task description. (Show Details)
• vyuen mentioned this in T312948: v0 Known Bugs to be fixed in v1.Jul 13 2022, 2:36 PM
Daimona added a subtask: T21992: Support client-side date/time formatting for user's timezone, language, and preferred format (JavaScript).Jul 14 2022, 2:47 PM
ldelench_wmf edited projects, added Connection-Team (Campaign-Tools-Sprint-17); removed Connection-Team (Campaign-Tools-Sprint-16).Jul 20 2022, 1:28 AM
ldelench_wmf added a parent task: T312948: v0 Known Bugs to be fixed in v1.Jul 20 2022, 1:42 AM
ifried renamed this task from Fix format of timestamps on the participants list on event details page [not v0] to Fix format of timestamps on the participants list on event details page.Aug 8 2022, 6:21 PM
ifried updated the task description. (Show Details)
• vyuen moved this task from Ready 🎬 to In Progress 💻 on the Connection-Team (Campaign-Tools-Sprint-17) board.Aug 10 2022, 12:44 PM
• vyuen added a subscriber: MHorsey-WMF.
ldelench_wmf moved this task from Backlog to V1 (MVP) on the Campaign-Registration board.Aug 10 2022, 3:45 PM
ldelench_wmf edited projects, added Connection-Team (Connection-Current-Sprint); removed Connection-Team (Campaign-Tools-Sprint-17).Aug 14 2022, 9:30 PM
ldelench_wmf moved this task from Upcoming / refining 💡 to Development In Progress 💻 on the Connection-Team (Connection-Current-Sprint) board.Aug 14 2022, 9:39 PM
MHorsey-WMF claimed this task.Aug 16 2022, 1:35 PM
Daimona merged a task: T311658: Update timestamp for registered participant info to user preference format.Aug 18 2022, 10:32 PM
gerritbot added a comment.Aug 19 2022, 1:38 PM

Change 824740 had a related patch set uploaded (by Mhorsey; author: Mhorsey):

[mediawiki/extensions/CampaignEvents@master] Fix format of timestamps on the participants list on event details page

https://gerrit.wikimedia.org/r/824740

gerritbot added a project: Patch-For-Review.Aug 19 2022, 1:38 PM
MHorsey-WMF moved this task from Development In Progress 💻 to Code Review 💬 on the Connection-Team (Connection-Current-Sprint) board.Aug 19 2022, 1:54 PM
Daimona updated the task description. (Show Details)Aug 19 2022, 2:47 PM
Daimona updated the task description. (Show Details)
Daimona moved this task from Code Review 💬 to QA 🐛 on the Connection-Team (Connection-Current-Sprint) board.Aug 24 2022, 12:24 PM
ldelench_wmf raised the priority of this task from Medium to High.Aug 26 2022, 7:05 PM
ldelench_wmf moved this task from V1 (MVP) to Darkship on the Campaign-Registration board.
vaughnwalters moved this task from QA 🐛 to Code Review 💬 on the Connection-Team (Connection-Current-Sprint) board.Aug 26 2022, 10:21 PM
vaughnwalters subscribed.

this isn't in master yet so moving it back to review/feedback until it is merged

• vyuen changed the task status from Open to In Progress.Aug 30 2022, 12:20 PM
Daimona removed a project: Patch-For-Review.Sep 1 2022, 12:15 PM
Daimona moved this task from Code Review 💬 to QA 🐛 on the Connection-Team (Connection-Current-Sprint) board.
gerritbot added a comment.Sep 1 2022, 12:18 PM

Change 824740 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Fix format of timestamps on the participants list on event details page

https://gerrit.wikimedia.org/r/824740

MHorsey-WMF mentioned this in rUCAM92498072ea36: Fix format of timestamps on the participants list on event details page.Sep 1 2022, 12:19 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.28; 2022-09-05).Sep 1 2022, 1:00 PM
vaughnwalters moved this task from QA 🐛 to Product sign-off 🤘 on the Connection-Team (Connection-Current-Sprint) board.EditedSep 1 2022, 8:53 PM
  • The date and time shown on the participants list on event details page should be consistently formatted according to user preference. currently, only the first 20 have the correct format:

Screen Recording 2022-09-01 at 3.07.38 PM.gif (1×1 px, 1 MB)

Screen Recording 2022-09-01 at 3.12.39 PM.gif (1×1 px, 2 MB)

Screen Recording 2022-09-01 at 3.38.46 PM.gif (1×1 px, 1 MB)

  • Documentation of the "List the participants of an event" endpoint should be updated to mention the new field and the format for both fields

https://www.mediawiki.org/wiki/Extension:CampaignEvents/Api#List_the_participants_of_an_event

"user_registered_at": "<timestamp, in TS_MW format>",
"user_registered_at_formatted": "<human-readable timestamp, formatted according to the user preferences>"

All AC passes 👍

ifried closed this task as Resolved.Sep 23 2022, 9:05 PM
ifried moved this task from Product sign-off 🤘 to Done 🏁 on the Connection-Team (Connection-Current-Sprint) board.

There is now a standard format for the timestamp of registration (see attached screenshot), so I'm marking this as Done.

Screen Shot 2022-09-23 at 5.04.10 PM.png (1×1 px, 96 KB)

Screen Shot 2022-09-23 at 5.04.32 PM.png (662×546 px, 51 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits