🟫 Create ReplaceItemStatement use case and implement happy path
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ollie.Shotton_WMDE
	Jul 13 2022, 3:21 PM

Description

add a StatementList::replaceStatement( StatementGuid $id, Statement $statement ): void method which ignores the new Statement object's id and sets it to $id
create a new ReplaceItemStatementRequest DTO with item id if present, statement id, statement serialization, tags list, bot flag, and user comment
create a new ReplaceItemStatementSuccessResponse DTO with statement serialization, revision ID, and revision timestamp
create a new ReplaceItemStatement use case:
- retrieve Item metadata
- use ItemRetriever, replace the Statement, then save using ItemUpdater
- return a ReplaceItemStatementSuccessResponse

Details

Subject	Repo	Branch	Lines +/-
Add StatementList::replaceStatement()	mediawiki/extensions/Wikibase	master	+66 -2
Improve StatementList::replaceStatement()	mediawiki/extensions/Wikibase	master	+1 -3
REST: Create ReplaceItemStatement use case	mediawiki/extensions/Wikibase	master	+384 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T344228 Functionality for REST API v1
Resolved	None	T306936 🟫 Replace item statement
Resolved	Silvan_WMDE	T312954 🟫 Create ReplaceItemStatement use case and implement happy path

Event Timeline

Ollie.Shotton_WMDE created this task.Jul 13 2022, 3:21 PM

Xqt added a subtask: T312957: Remove Python 3.5 dependency.Jul 13 2022, 3:49 PM

Xqt removed a subtask: T312957: Remove Python 3.5 dependency.Jul 13 2022, 3:53 PM

Ollie.Shotton_WMDE updated the task description. (Show Details)Jul 13 2022, 5:19 PM

Ollie.Shotton_WMDE updated the task description. (Show Details)Jul 19 2022, 9:37 AM

Ollie.Shotton_WMDE updated the task description. (Show Details)

Silvan_WMDE claimed this task.Jul 19 2022, 10:54 AM

Silvan_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 10) board.

Change 815332 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] Add StatementList::replaceStatement()

https://gerrit.wikimedia.org/r/815332

gerritbot added a project: Patch-For-Review.Jul 19 2022, 5:13 PM

Change 815692 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] REST: Create ReplaceItemStatement use case

https://gerrit.wikimedia.org/r/815692

Silvan_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 10) board.Jul 20 2022, 10:05 AM

Change 815332 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add StatementList::replaceStatement()

https://gerrit.wikimedia.org/r/815332

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.22; 2022-07-25).Jul 20 2022, 2:00 PM

Change 815692 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Create ReplaceItemStatement use case

https://gerrit.wikimedia.org/r/815692

Change 815992 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] Improve StatementList::replaceStatement()

https://gerrit.wikimedia.org/r/815992

Silvan_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 10) board.Jul 22 2022, 9:19 AM

Change 815992 merged by jenkins-bot: