Page MenuHomePhabricator
Create Task
Maniphest T313002

Browser's autoscroll doesn't work well with sticky outline header
Closed, InvalidPublic
Actions

Description

Normally the browser takes care that the item currently highlighted in the SelectWidget when using keyboard interaction is scrolled into view. This is not working well with our current setup where we use the sticky header part.

One workaround applied for this at the moment is triggering our own scrolling during keyboard navigation that respects the offset caused by the sticky part. Still it would be good if we could remove this workaround, when we find a way to allow the browser applying the correct scroll offset itself. See also [1]

Also this is currently causing this visible jump tracked in T312768: Regression: Parameter list jumps when being focused in chrome

[1] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/813638

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
[WIP] Move menu scrollable container further inmediawiki/extensions/VisualEditormaster+32 -45
Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-Fisch created this task.Jul 14 2022, 1:13 AM
WMDE-Fisch removed WMDE-Fisch as the assignee of this task.Jul 14 2022, 6:08 AM
awight renamed this task from Browser's autoscoll doesn't work well with sticky outline header to Browser's autoscroll doesn't work well with sticky outline header.Jul 14 2022, 10:31 AM
awight claimed this task.
awight added a parent task: T312926: Regression: mouse hover at top of the parameter list causing automatic scrolling (VE template dialog).
awight moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-07-06 board.
awight removed awight as the assignee of this task.Jul 14 2022, 2:22 PM
awight moved this task from Doing to Sprint Backlog on the WMDE-TechWish-Sprint-2022-07-06 board.
awight subscribed.

In theory, scroll-padding might help with this issue, but I couldn't get anything to work when experimenting. It's also strange that if you cursor up through the parameters, the list scrolls to put the focused line directly under the sticky header, until the top several items, when the focus goes under the header. Why would that be? Either the browser knows how to keep the text visible or not...?

Setting aside for the day.

WMDE-Fisch claimed this task.Jul 15 2022, 9:22 AM
WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-07-06 board.
gerritbot added a comment.Jul 18 2022, 7:23 AM

Change 814685 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@master] [WIP] Move scrollable containers further in

https://gerrit.wikimedia.org/r/814685

gerritbot added a project: Patch-For-Review.Jul 18 2022, 7:23 AM
awight removed WMDE-Fisch as the assignee of this task.Jul 18 2022, 11:49 AM
lilients_WMDE moved this task from Backlog to In sprint on the WMDE-Templates-FocusArea board.Jul 18 2022, 12:53 PM
thiemowmde moved this task from Doing to Sprint Backlog on the WMDE-TechWish-Sprint-2022-07-06 board.Jul 18 2022, 2:37 PM
thiemowmde closed this task as Invalid.Jul 18 2022, 2:41 PM
WMDE-Fisch mentioned this in T312926: Regression: mouse hover at top of the parameter list causing automatic scrolling (VE template dialog).Aug 1 2022, 12:19 PM
gerritbot added a comment.Jan 13 2023, 4:04 PM

Change 814685 abandoned by WMDE-Fisch:

[mediawiki/extensions/VisualEditor@master] [WIP] Move menu scrollable container further in

Reason:

Will not continue working on this.

https://gerrit.wikimedia.org/r/814685

Maintenance_bot removed a project: Patch-For-Review.Jan 13 2023, 4:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits