Page MenuHomePhabricator
Create Task
Maniphest T313021

🟫 Validate ReplaceItemStatement use case input
Closed, ResolvedPublic
Actions

Description

Similar to T312552 (validate item ID if present, statement ID, edit metadata), but also validating the statement serialization using the StatementValidator that was created in T309843.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
REST: Validate ReplaceItemStatement use case inputmediawiki/extensions/Wikibasemaster+590 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jakob_WMDE created this task.Jul 14 2022, 12:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 14 2022, 12:33 PM
WMDE-leszek edited projects, added Wikibase Product Platform (v1) (Sprint 11); removed Wikibase Product Platform (v1) (Sprint 10).Jul 27 2022, 9:19 AM
Ollie.Shotton_WMDE claimed this task.Jul 29 2022, 4:39 PM
Ollie.Shotton_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 11) board.
gerritbot added a comment.Aug 1 2022, 4:05 PM

Change 819110 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Validate ReplaceItemStatement use case input

https://gerrit.wikimedia.org/r/819110

gerritbot added a project: Patch-For-Review.Aug 1 2022, 4:05 PM
Ollie.Shotton_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 11) board.Aug 2 2022, 8:15 AM
Ollie.Shotton_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 11) board.Aug 3 2022, 1:31 PM
gerritbot added a comment.Aug 3 2022, 1:32 PM

Change 819110 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Validate ReplaceItemStatement use case input

https://gerrit.wikimedia.org/r/819110

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 3 2022, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 3 2022, 2:31 PM
Aklapper closed this task as Resolved.Oct 10 2022, 9:53 AM

@Ollie.Shotton_WMDE: Assuming this task is resolved. Thus setting resolved task status. Please reopen and add an active project tag if that is not the case. Thanks.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits