Page MenuHomePhabricator
Create Task
Maniphest T313069

Don't send failmail on Adyen unsupported card
Closed, ResolvedPublic
Actions

Description

When a donor tries to use a card that Adyen can't find an acquirer for, we show them an error message and also send a failmail.

The donor-facing error should be enough. Stop sending the failmail.

This has happened most frequently trying to accept EUR donations in European countries via UATP cards and Korean local cards.

We should probably add another error code to the SmashPig error enum and map Adyen error 905_1 to that.

Details

SubjectRepoBranchLines +/-
Adyen: Don't failmail on 500 status with errorCodewikimedia/fundraising/SmashPigmaster+81 -0
Fix failmail on Adyen unsupported card: Take 2wikimedia/fundraising/SmashPigmaster+107 -34
Break up big functionwikimedia/fundraising/SmashPigmaster+100 -73
Move Adyen error code 905_1 from fatal to validationwikimedia/fundraising/SmashPigmaster+2 -2
Customize query in gerrit

Event Timeline

Ejegg created this task.Jul 14 2022, 5:14 PM
Restricted Application added subscribers: revi, Aklapper. · View Herald TranscriptJul 14 2022, 5:14 PM
AnnWF added a project: FR-Alerts.Jul 15 2022, 9:50 PM
gerritbot added a comment.Jul 18 2022, 9:17 PM

Change 814903 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Move Adyen error code 905_1 from fatal to validation

https://gerrit.wikimedia.org/r/814903

gerritbot added a project: Patch-For-Review.Jul 18 2022, 9:17 PM
gerritbot added a comment.Jul 22 2022, 7:02 PM

Change 814903 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Move Adyen error code 905_1 from fatal to validation

https://gerrit.wikimedia.org/r/814903

Maintenance_bot removed a project: Patch-For-Review.Jul 22 2022, 7:30 PM
greg added a project: Fundraising Sprint Machine Unlearning.Jul 25 2022, 8:16 PM
greg moved this task from Backlog to Pending Deployment on the Fundraising Sprint Machine Unlearning board.
greg moved this task from Triage to Current Sprint on the Fundraising-Backlog board.
Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Machine Unlearning board.Jul 27 2022, 2:24 AM

This fix went out with the Adyen 3DSecure fix. Hopefully we will never get email about UATP again!

Ejegg moved this task from Done to Doing on the Fundraising Sprint Machine Unlearning board.Jul 28 2022, 3:20 AM

Hmm, we're still getting failmail on these errors. I guess it wasn't as simple as just moving it to the validation errors column. Maybe it's still failmailing because of the 500 HTTP status?

XenoRyet added a project: Fundraising Sprint NaN is a Number.Aug 2 2022, 8:41 PM
gerritbot added a comment.Aug 3 2022, 2:19 AM

Change 819775 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Break up big function

https://gerrit.wikimedia.org/r/819775

gerritbot added a project: Patch-For-Review.Aug 3 2022, 2:19 AM
gerritbot added a comment.Aug 4 2022, 1:37 AM

Change 819776 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Fix failmail on Adyen unsupported card: Take 2

https://gerrit.wikimedia.org/r/819776

gerritbot added a comment.Aug 4 2022, 8:13 PM

Change 819775 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Break up big function

https://gerrit.wikimedia.org/r/819775

gerritbot added a comment.Aug 4 2022, 8:13 PM

Change 819776 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Fix failmail on Adyen unsupported card: Take 2

https://gerrit.wikimedia.org/r/819776

Maintenance_bot removed a project: Patch-For-Review.Aug 4 2022, 8:30 PM
Ejegg moved this task from Backlog to Done on the Fundraising Sprint NaN is a Number board.Aug 9 2022, 2:31 AM
Ejegg moved this task from Done to Doing on the Fundraising Sprint NaN is a Number board.Aug 15 2022, 10:53 PM
Ejegg added a comment.Aug 15 2022, 11:00 PM

The failmails are still happening. The previous fixes were definitely good to have, but there is still one more change to make so we don't log anything at error level in the SmashPig RestResponseValidator.

gerritbot added a comment.Aug 15 2022, 11:11 PM

Change 823270 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Adyen: Don't failmail on 500 status with errorCode

https://gerrit.wikimedia.org/r/823270

gerritbot added a project: Patch-For-Review.Aug 15 2022, 11:11 PM
Ejegg claimed this task.Aug 16 2022, 7:10 PM
Ejegg triaged this task as Medium priority.
Ejegg moved this task from Doing to Review on the Fundraising Sprint NaN is a Number board.
XenoRyet added a project: Fundraising Sprint Overused petting Zoo Memetics.Aug 16 2022, 8:11 PM
AnnWF moved this task from Backlog to Review on the Fundraising Sprint Overused petting Zoo Memetics board.Aug 17 2022, 12:22 AM
gerritbot added a comment.Aug 19 2022, 4:19 PM

Change 823270 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Adyen: Don't failmail on 500 status with errorCode

https://gerrit.wikimedia.org/r/823270

Maintenance_bot removed a project: Patch-For-Review.Aug 19 2022, 4:30 PM
AnnWF moved this task from Review to Pending Deployment on the Fundraising Sprint Overused petting Zoo Memetics board.Aug 19 2022, 4:41 PM
Ejegg moved this task from Pending Deployment to Doing on the Fundraising Sprint Overused petting Zoo Memetics board.Aug 25 2022, 7:02 PM
Ejegg moved this task from Doing to Done on the Fundraising Sprint Overused petting Zoo Memetics board.Aug 25 2022, 7:39 PM

Oops, I moved this one backwards when I meant to move a different one backwards. I think this one is actually done now!

XenoRyet closed this task as Resolved.Aug 30 2022, 7:06 PM
XenoRyet set Final Story Points to 4.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL