Page MenuHomePhabricator

Reply tool corruption involving {{Desbloqueo revisado}} on es.wp
Closed, ResolvedPublic

Description

Reply tool corruption involving {{Desbloqueo revisado}} on es.wp:

It looks like some content from the template gets duplicated.

Event Timeline

Seems to be a bug on our side and not in Parsoid, we're adding the reply in the middle of the template for some reason.

image.png (1×1 px, 187 KB)

ppelberg moved this task from Untriaged to Upcoming on the Editing-team board.
ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.

Change 840328 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Add test case for T313100

https://gerrit.wikimedia.org/r/840328

Change 840329 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Place replies outside transclusions, disallow replying to transcluded comments

https://gerrit.wikimedia.org/r/840329

Change 840328 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Add test case for T313100

https://gerrit.wikimedia.org/r/840328

Change 840329 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Place replies outside transclusions, disallow replying to transcluded comments

https://gerrit.wikimedia.org/r/840329

Studying the attached links shows that the signature(and not the content) is what's duplicated in all three cases.

@matmarex , could you please confirm that my deductions are correct or close?

Testing from this point of view, fix looks like

Screenshot 2022-12-02 at 02.20.31.png (1×3 px, 321 KB)

Yes, the signature and a bit of template markup (but not comment content) were affected. Thanks for checking.