Page MenuHomePhabricator
Create Task
Maniphest T313143

Math seems to have an unintended hard dependancy on Wikibase - "Error: Unknown module: mw.config.values.wbRepo"
Closed, ResolvedPublic
Actions

Description

Seen on my dev wiki...

Screenshot 2022-07-16 at 02.27.10.png (268×690 px, 14 KB)

Loading… doesn't seem to change into anything else. No obvious network requests

Details

SubjectRepoBranchLines +/-
Fix broken MathSearchHooksTestmediawiki/extensions/MathSearchREL1_39+4 -21
Fix broken MathSearchHooksTestmediawiki/extensions/MathSearchmaster+4 -21
Make dependency to Wikibase client config optionalmediawiki/extensions/Mathmaster+123 -17
Revert "Revert "Add wbEntitySelector widget to edit qid in VE""mediawiki/extensions/Mathmaster+5 -3
Revert "Add wbEntitySelector widget to edit qid in VE"mediawiki/extensions/Mathmaster+3 -5
Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Jul 16 2022, 1:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 16 2022, 1:27 AM
Reedy updated the task description. (Show Details)Jul 16 2022, 1:27 AM
Reedy updated the task description. (Show Details)
Novem_Linguae subscribed.Jul 16 2022, 12:07 PM

Probably need steps to reproduce right? Any hints as to the page's wikitext, where you clicked reply, any JS console errors?

Reedy added a comment.Jul 16 2022, 12:47 PM

I didn't click reply, I clicked Add Topic.

The page is empty.

No (relevant) console errors.

matmarex subscribed.Jul 16 2022, 4:14 PM

Can you enable "Pause on caught exceptions" in your browser's debugger, then click the button and see what happens? Something is probably throwing an error, but it gets caught and ignored somewhere in promise handling.

FirefoxChrome
image.png (2×3 px, 248 KB)
image.png (2×3 px, 261 KB)
Reedy added a comment.Jul 16 2022, 5:19 PM

In the request w/load.php?lang=en-gb&modules=startup&only=scripts&raw=1&skin=vector

Paused on exception
Error: Unknown module: mw.config.values.wbRepo
Reedy added a comment.Jul 16 2022, 5:21 PM

Then...

Paused on exception
SyntaxError: Element.querySelectorAll: '\' is not a valid selector
Reedy added a comment.Jul 16 2022, 5:27 PM

It looks like if I disable the Math extension (it's about the only thing that depends on mw.config.values.wbRepo outside Wikibase/Wikibase related extensions) it loads...

Based on

In T313143#8082331, @Reedy wrote:
Paused on exception
Error: Unknown module: mw.config.values.wbRepo

I wonder if it's making some assumptions in code that the Wikibase config (and modules?) will be loaded, which isn't guaranteed...

Reedy edited projects, added Math, Regression; removed DiscussionTools.Jul 16 2022, 5:29 PM

rEMAT422be143f644: Add wbEntitySelector widget to edit qid in VE looks suspicious.

Reedy renamed this task from DiscussionTools doesn't seem to load to Math seems to have an unintended hard dependancy on Wikibase - "Error: Unknown module: mw.config.values.wbRepo".Jul 16 2022, 5:30 PM
gerritbot added a comment.Jul 16 2022, 5:40 PM

Change 814322 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Math@master] Revert "Add wbEntitySelector widget to edit qid in VE"

https://gerrit.wikimedia.org/r/814322

gerritbot added a project: Patch-For-Review.Jul 16 2022, 5:40 PM
gerritbot added a comment.Jul 17 2022, 9:59 AM

Change 814348 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[mediawiki/extensions/Math@master] Make dependency to Wikibase client config optional

https://gerrit.wikimedia.org/r/814348

Novem_Linguae unsubscribed.Jul 17 2022, 10:01 AM
gerritbot added a comment.Jul 17 2022, 11:10 AM

Change 814322 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Revert "Add wbEntitySelector widget to edit qid in VE"

https://gerrit.wikimedia.org/r/814322

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 17 2022, 12:01 PM
matmarex merged a task: T313179: Can't use VisualEditor.Jul 17 2022, 1:46 PM
matmarex added a subscriber: Bluehill395.
gerritbot added a comment.Jul 20 2022, 3:51 PM

Change 815730 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[mediawiki/extensions/Math@master] Revert "Revert "Add wbEntitySelector widget to edit qid in VE""

https://gerrit.wikimedia.org/r/815730

gerritbot added a comment.Jul 25 2022, 7:21 AM

Change 815730 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Revert "Revert "Add wbEntitySelector widget to edit qid in VE""

https://gerrit.wikimedia.org/r/815730

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.22; 2022-07-25); removed MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 25 2022, 8:00 AM
gerritbot added a comment.Jul 25 2022, 8:48 AM

Change 814348 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Make dependency to Wikibase client config optional

https://gerrit.wikimedia.org/r/814348

Maintenance_bot removed a project: Patch-For-Review.Jul 25 2022, 9:30 AM
Bluehill395 unsubscribed.Jul 25 2022, 2:16 PM
matmarex closed this task as Resolved.Jul 25 2022, 4:28 PM

Resolved I guess? Thanks!

Physikerwelt claimed this task.Jul 25 2022, 4:30 PM
Physikerwelt subscribed.

Yes. I hope so.

gerritbot added a comment.Dec 1 2022, 6:40 PM

Change 863019 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/MathSearch@master] Fix broken MathSearchHooksTest

https://gerrit.wikimedia.org/r/863019

gerritbot added a project: Patch-For-Review.Dec 1 2022, 6:40 PM
gerritbot added a comment.Dec 1 2022, 7:58 PM

Change 863019 merged by jenkins-bot:

[mediawiki/extensions/MathSearch@master] Fix broken MathSearchHooksTest

https://gerrit.wikimedia.org/r/863019

thiemowmde mentioned this in rEMASae25fb7eb1dc: Fix broken MathSearchHooksTest.Dec 1 2022, 8:01 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 1 2022, 8:30 PM
gerritbot added a comment.Dec 4 2022, 7:10 PM

Change 863358 had a related patch set uploaded (by Umherirrender; author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/MathSearch@REL1_39] Fix broken MathSearchHooksTest

https://gerrit.wikimedia.org/r/863358

gerritbot added a project: Patch-For-Review.Dec 4 2022, 7:10 PM
gerritbot added a comment.Dec 4 2022, 7:44 PM

Change 863358 merged by jenkins-bot:

[mediawiki/extensions/MathSearch@REL1_39] Fix broken MathSearchHooksTest

https://gerrit.wikimedia.org/r/863358

Umherirrender mentioned this in rEMASe778274ded1a: Fix broken MathSearchHooksTest.Dec 4 2022, 7:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL