[Refactor] Select on spacebar event triggers twice in new template dialog sidebar
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	thiemowmde
	Jul 18 2022, 9:43 AM

Description

Steps to reproduce:

Set a breakpoint or debug.log( … ) at the start of TransclusionOutlineWidget.setSelectionByPageName.
Edit a multi-part template.
Use the keyboard to navigate to a template name in the sidebar.
Press space.

Patch-For-Review:

https://gerrit.wikimedia.org/r/814189

Details

	Subject	Repo	Branch	Lines +/-
	Remove duplicate selection code from template dialog sidebar	mediawiki/extensions/VisualEditor	master	+0 -1

Customize query in gerrit

Event Timeline

thiemowmde created this task.Jul 18 2022, 9:43 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 18 2022, 9:43 AM

thiemowmde claimed this task.Jul 18 2022, 9:43 AM

thiemowmde set the point value for this task to 1.

thiemowmde moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2022-07-06 board.

Change 814189 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Remove duplicate selection code from template dialog sidebar

https://gerrit.wikimedia.org/r/814189

gerritbot added a project: Patch-For-Review.Jul 18 2022, 9:44 AM

lilients_WMDE moved this task from Backlog to In sprint on the WMDE-Templates-FocusArea board.Jul 18 2022, 12:53 PM

awight renamed this task from Select on spacebar event triggers twice in new template dialog sidebar to [Refactor] Select on spacebar event triggers twice in new template dialog sidebar.Jul 19 2022, 10:34 AM

thiemowmde added a project: WMDE-TechWish-Sprint-2022-07-20.Jul 20 2022, 8:08 AM

thiemowmde moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2022-07-20 board.

lilients_WMDE moved this task from Tech Review to Done on the WMDE-TechWish-Sprint-2022-07-20 board.Jul 20 2022, 9:54 AM

Change 814189 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove duplicate selection code from template dialog sidebar

https://gerrit.wikimedia.org/r/814189

Maintenance_bot removed a project: Patch-For-Review.Jul 20 2022, 10:30 AM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.22; 2022-07-25).Jul 20 2022, 11:00 AM

thiemowmde closed this task as Resolved.Aug 2 2022, 8:15 AM