Line height too low on VE target widgets
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Jul 18 2022, 12:54 PM

Description

Open a image dialog with a long caption that wraps across multiple lines.

The line height should be 1.6, but is one 1:

Observed	Expected

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Add 'vector-body' hack to TargetWidgets	mediawiki/extensions/VisualEditor	master	+8 -1

Mentioned In: T315596: [SPIKE] Audit places in VE that depend on skin font size
Mentioned Here: T314230: Adding a wikilink in basic reference shows overlay error
T287733: 2017 wikitext editor preview and visual diff has wrong line-height and font-size on Vector

This is the same cause as T287733.

Change 814804 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Add 'vector-body' hack to TargetWidgets

Esanders renamed this task from Line height too lower on VE target widgets to Line height too low on VE target widgets.Jul 18 2022, 1:12 PM

Change 814804 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Add 'vector-body' hack to TargetWidgets

• matmarex moved this task from To Triage to Triaged on the VisualEditor board.

✅ Line height has the right size

ppelberg closed this task as Resolved.Jul 22 2022, 1:34 AM

ppelberg claimed this task.

Not reverting after all.

	F35320951: Screenshot 2022-07-19 at 02.13.20.png
	Jul 19 2022, 1:15 AM

	F35320949: Screenshot 2022-07-19 at 02.12.44.png
	Jul 19 2022, 1:15 AM