Page MenuHomePhabricator

Unify and clean up Less variables usage
Closed, ResolvedPublic2 Estimated Story Points

Description

Goal

List of mixed variable names across the codebase:

Acceptance criteria

Sidebar.less

  • margin-top: @top-margin-sidebar-toc;

ArticleToolbar

  • border-bottom; @border-tabs > border-bottom; @border-bottom-tabs

Header.less
[] min-height : height-logo-icon > size-logo-icon?
height determined to be potentially different that width per T245190

LanguageButton

  • @button-padding

TableofContents
padding: @sidebar-toc-vertical-padding @sidebar-toc-right-padding @sidebar-toc-vertical-padding 32px;
width: @toc-subsection-toggle-icon-size

UserLinks
color: @colorGray5;
Dev note For the last one, I've added a question in https://www.figma.com/file/E6hxGwEOs9YFVF4fFRyqSv/Colors-Tokens---T296995?node-id=699%3A18822 as we need a color token for this color.

Event Timeline

Change 814874 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/skins/Vector@master] styles: Replace distinct color var with standard variable

https://gerrit.wikimedia.org/r/814874

Change 815242 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/skins/Vector@master] styles: Use mediawiki.skin.variables `transition-duration` vars

https://gerrit.wikimedia.org/r/815242

Change 815243 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/skins/Vector@master] styles: Rename `border-tabs` to `border-bottom-tabs`

https://gerrit.wikimedia.org/r/815243

Change 815246 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/skins/Vector@master] styles: Apply `@background` var to Sidebar `background`

https://gerrit.wikimedia.org/r/815246

Change 815252 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/skins/Vector@master] styles: Use default `border-width` and `border-style` vars

https://gerrit.wikimedia.org/r/815252

Change 814874 merged by jenkins-bot:

[mediawiki/skins/Vector@master] styles: Replace distinct color var with standard variable

https://gerrit.wikimedia.org/r/814874

Change 815242 merged by jenkins-bot:

[mediawiki/skins/Vector@master] styles: Use mediawiki.skin.variables `transition-duration` vars

https://gerrit.wikimedia.org/r/815242

Change 815243 merged by jenkins-bot:

[mediawiki/skins/Vector@master] styles: Rename `border-tabs` to `border-bottom-tabs`

https://gerrit.wikimedia.org/r/815243

Change 815246 merged by jenkins-bot:

[mediawiki/skins/Vector@master] styles: Apply `@background` var to Sidebar `background`

https://gerrit.wikimedia.org/r/815246

Change 815252 merged by jenkins-bot:

[mediawiki/skins/Vector@master] styles: Use default `border-width` and `border-style` vars

https://gerrit.wikimedia.org/r/815252

Jdlrobson set the point value for this task to 2.

Change 815358 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/skins/Vector@master] styles: Replace `@top-margin…` with `@margin-top…` variable names

https://gerrit.wikimedia.org/r/815358

Change 815725 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/skins/Vector@master] styles: Replace LanguageButton variables nomenclature

https://gerrit.wikimedia.org/r/815725

Volker_E updated the task description. (Show Details)

Change 815358 merged by jenkins-bot:

[mediawiki/skins/Vector@master] styles: Replace `@top-margin…` with `@margin-top…` variable names

https://gerrit.wikimedia.org/r/815358

Change 815725 merged by jenkins-bot:

[mediawiki/skins/Vector@master] styles: Replace LanguageButton variable nomenclature

https://gerrit.wikimedia.org/r/815725

Jdrewniak removed Jdrewniak as the assignee of this task.
Jdrewniak updated the task description. (Show Details)
Jdrewniak subscribed.