Setting $wgStrictFileExtensions to false gives incorrect warning
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	• bzimport
	Jun 9 2011, 12:44 PM

Description

Author: mediawiki

Description:
... The warning in question is for example

(example)
".txt" is an unwanted file type. Preferred file types are $2.
(/example)

Note the $2.

Version: 1.16.x
Severity: minor

Details

Reference: bz29325

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:29 PM

• bzimport added a project: MediaWiki-General.

• bzimport set Reference to bz29325.

• bzimport added a subscriber: Unknown Object (MLST).

• bzimport created this task.Jun 9 2011, 12:44 PM

Confirmed still present in trunk.

Looks like the warning message gets set in UploadBase::checkWarnings(), but parameters for those messages don't get added until output time in SpecialUpload::showUploadWarning.

That function has some special cases for specific warning messages to customize the output; the one to watch for is 'filetype-unwanted-type'.

The similar 'filetype-banned-type' message is processed separately in SpecialUpload::processVerificationError, so may need some common list building.

Fixed in r90369.

Setting $wgStrictFileExtensions to false gives incorrect warningClosed, ResolvedPublicActions

Description

Details

Event Timeline

Setting $wgStrictFileExtensions to false gives incorrect warning
Closed, ResolvedPublic
Actions