Page MenuHomePhabricator
Create Task
Maniphest T313294

Regression: clicking on a template heading in the sidebar forces any parameters scrolled off the bottom to come into view
Closed, DeclinedPublic2 Estimated Story Points
Actions

Description

Steps to reproduce:

  • Given a multi-part transclusion with a template at the bottom of the sidebar, whose parameters extend beyond the screen:

image.png (301×948 px, 20 KB)

  • Click the template heading in the sidebar.

What happens:

  • The sidebar scrolls so that all parameters are visible.

image.png (373×933 px, 30 KB)

What should have happened:

  • Sidebar should not scroll.

Related Objects
Search...

Event Timeline

awight created this task.Jul 19 2022, 9:11 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 19 2022, 9:11 AM
thiemowmde added projects: Regression, Unplanned-Sprint-Work.Jul 19 2022, 2:06 PM
thiemowmde set the point value for this task to 2.
thiemowmde added subscribers: thiemowmde, lilients_WMDE.
ppelberg moved this task from To Triage to Triaged on the VisualEditor board.Jul 28 2022, 3:54 PM
gerritbot added a comment.Aug 2 2022, 11:39 AM

Change 819556 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] [WIP] Stop scrolling template parameter lists into view

https://gerrit.wikimedia.org/r/819556

gerritbot added a project: Patch-For-Review.Aug 2 2022, 11:39 AM
WMDE-Fisch moved this task from Backlog to Ready for pickup on the WMDE-Templates-FocusArea board.Aug 3 2022, 9:01 AM
WMDE-Fisch added a project: WMDE-TechWish-Sprint-2022-08-03.
WMDE-Fisch moved this task from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.
WMDE-Fisch moved this task from Sprint Backlog to UX/PM Review on the WMDE-TechWish-Sprint-2022-08-03 board.Aug 3 2022, 9:06 AM
WMDE-Fisch subscribed.

Note: This is a behavior we found weird but are not sure if we should fix it or leave it like that. UX feedback needed. :-)
P.S.: Fix is already there so the effort is kind of zero to fix it.

lilients_WMDE removed a project: Unplanned-Sprint-Work.Aug 3 2022, 1:28 PM
thiemowmde closed this task as Declined.Aug 11 2022, 10:56 AM
thiemowmde added a subscriber: ECohen_WMDE.

Working as intended. As discussed in story time this week.

WMDE-Fisch moved this task from UX/PM Review to Done on the WMDE-TechWish-Sprint-2022-08-03 board.Aug 17 2022, 7:53 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits