Page MenuHomePhabricator

QuickSurveys should not depend on EventLogging
Closed, ResolvedPublicFeature

Description

Feature summary (what you would like to be able to do and where):

  • QuickSurveys supports logging an event when a survey is shown, and recording survey results to an EventLogging schema. We tend to discourage the latter because of T256463#7804579
  • WikimediaEvents is the defacto place for EventLogging in WMF product to occur so all event logging code should move there. We should use a mw.track inside QuickSurveys

Benefits (why should this be implemented?):

  • Easier for people to get setup with QuickSurveys - no need to install EventLogging unless you are explicitly working on the data collection portion
  • Better code organization - having the event logging code in WikimediaEvents alongside other event logging code is beneficial.

Event Timeline

Change 815387 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/QuickSurveys@master] Make EventLogging a soft dependency on QuickSurveys

https://gerrit.wikimedia.org/r/815387

Change 815393 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/QuickSurveys@master] Refactor QuickSurveys use of event logging

https://gerrit.wikimedia.org/r/815393

Change 815393 merged by jenkins-bot:

[mediawiki/extensions/QuickSurveys@master] Refactor QuickSurveys use of event logging

https://gerrit.wikimedia.org/r/815393

Change 815387 merged by jenkins-bot:

[mediawiki/extensions/QuickSurveys@master] Make EventLogging a soft dependency on QuickSurveys

https://gerrit.wikimedia.org/r/815387

Change 815801 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/QuickSurveys@master] Logging: Restore logging of responses

https://gerrit.wikimedia.org/r/815801

Change 815801 merged by jenkins-bot:

[mediawiki/extensions/QuickSurveys@master] Logging: Restore logging of responses

https://gerrit.wikimedia.org/r/815801