Maniphest T313406

Subscribe link wraps under section edit link
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Jul 20 2022, 1:03 PM

Tags

Referenced Files

	F35323136: image.png
	Jul 20 2022, 1:03 PM

	F35323133: image.png
	Jul 20 2022, 1:03 PM

Subscribers

Description

Without visual enhancements enabled, the subscribe link stays at the bottom of a wrapped heading, which can look odd:

image.png (366×1 px, 119 KB)

If we move the link before the title in the DOM it looks more sensible:

image.png (388×890 px, 123 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Prepend subscribe links to headings	mediawiki/extensions/DiscussionTools	master	+323 -323

Customize query in gerrit

Related Objects

Mentioned In: T13555: .mw-editsection links should not be part of the <h#> element

Event Timeline

Esanders created this task.Jul 20 2022, 1:03 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 20 2022, 1:03 PM

Esanders claimed this task.Jul 20 2022, 1:06 PM

Esanders added a project: Editing-team (Kanban Board).

Esanders moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.

Change 815711 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Prepend subscribe links to headings

https://gerrit.wikimedia.org/r/815711

gerritbot added a project: Patch-For-Review.Jul 20 2022, 1:07 PM

Change 815711 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Prepend subscribe links to headings

https://gerrit.wikimedia.org/r/815711

Maintenance_bot removed a project: Patch-For-Review.Jul 27 2022, 2:30 PM

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Jul 27 2022, 2:44 PM

matmarex added a project: Editing QA.

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.23; 2022-08-01).Jul 27 2022, 3:00 PM

• ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Jul 28 2022, 3:11 PM

Ryasmeen edited projects, added Verified; removed Editing QA.Jul 28 2022, 9:41 PM

matmarex added a project: Editing QA.Aug 5 2022, 10:37 PM

matmarex removed a project: Editing QA.Aug 5 2022, 10:38 PM

matmarex moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.

• ppelberg closed this task as Resolved.Aug 13 2022, 12:09 AM

matmarex mentioned this in T13555: .mw-editsection links should not be part of the <h#> element.Sep 24 2022, 10:56 PM