Page MenuHomePhabricator

allow overwriting wikit's default font
Closed, ResolvedPublic5 Estimated Story Points

Description

As a wikit implementer I want to be able to define my own fonts in order to tie in wikit to already existing frontends.

Problem:
Wikit currently does not allow overwriting its default fonts. This causes an issue with implementation in wikis that use skins other than minerva neue.

Example:
see T313166

Acceptance criteria:

  • wiki allows overwriting of its default fonts

Notes:

  • Michael suggested a solution in T313166#8090807, which is to use sas mixins to overwrite the font families.

Event Timeline

Notes from discussion with @Michael:

The solution of adding arguments to the Typography mixin and then unsetting it will probably not resolve this issue as Special:NewLexemeAlpha (for example) does not use said mixins for labels and placeholders.
The question that came up is - should Wikit set fonts at all? In such case it would call for a larger scale action.

This may require its own ticket, but may I request that the open source Noto Nastaleeq Urdu font be hosted as a web font and then used for all Urdu and Punjabi Shahmukhi text by default? There are characters this font includes that most fonts don't render, and while I have a custom stylesheet for this on desktop, I can't see certain letters on my phone because of this.

@mrephabricator Yes please open a separate ticket for this so the right people can see it and work on it.

sprint 4 planning -
Task scope is larger than initially expected. Will be returned to the backlog to be reassessed.

Draft PR to document what was tried on this issue so far:
https://github.com/wmde/wikit/pull/631

This task is postponed until we have more clarity regarding the future of WiKit.

As discussed, major changes to wikit will not be developed. This task does not meet the requirements for an exception to this policy, as such I am resolving it. @Lydia_Pintscher , please review and close