Page MenuHomePhabricator

Editing a story with the nojs form wipes the 'originalText' fields
Closed, ResolvedPublicBUG REPORT


Steps to replicate the issue (include links if applicable):

  • Create a story with the Story Builder
  • Edit the story with the nojs form (add a single char to a frame text)

What happens?:

  • if you look at the page history, the edit appears to have deleted a lot of bytes. Inspecting the json from the DB reveals that the 'originalText' fields are gone

What should have happened instead?:

  • The edit from the form should have been merged with the existing content to preserve the original text that was selected from the article when the story was first created.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Related Objects

Event Timeline

SBisson triaged this task as Medium priority.Jul 28 2022, 12:46 PM
SBisson moved this task from Backlog to R2 on the Wikistories board.
SBisson edited projects, added Wikistories (R2); removed Wikistories.
SBisson edited projects, added Inuka-Team (Kanban); removed Inuka-Team.

Change 818211 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/Wikistories@master] Preserve articleTitle and originalText in hidden fields

Change 818211 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Preserve articleTitle and originalText in hidden fields

EUdoh-WMF added a subscriber: EUdoh-WMF.

Looks good to me.