Page MenuHomePhabricator

docs/build: Increase easy or automatic resolution of minor code issues
Open, MediumPublic3 Estimated Story Points

Description

The more we can both automate fixes of easy-to-catch code issues and ensure that developers can easily access this automation, the less time and energy we have to spend on these issues during the code review process. In addition to saving time, this can reduce the number of comments on a patch, which helps avoid noise and put focus on the important discussions.

Some ideas:

  • Add instructions to the development basics section of our code contribution docs for setting up a local environment to take advantage of this automation. This could include:
    • Adding and configuring extensions to VSCode, including Vetur/Volar, ESLint, Stylelint, Code Spell Checker, and Markdown Preview Enhanced. This will help developers catch issues identified by linters, spelling errors, and Markdown syntax issues during development. We could consider a shared vscode config file that would automatically take care of this.
    • Instructions for running linters and autofixing issues
  • Consider a pre-commit hook to encourage running tests locally before pushing patches
  • Add commit-message-validator

Acceptance criteria
  • Consider what else we could automate or better explain in the docs. Collect ideas from the team.
  • Make a list of the things we're going to implement here in the acceptance criteria
  • Complete those items

Event Timeline

@Catrope @Volker_E @egardner Let me know if you have any preferences here or other ideas!

Please consider prioritizing T309899: Document how to build documentation within fresh node - we should not encourage new developers to be installing and running NPM scripts directly, https://timotijhof.net/posts/2019/protect-yourself-from-npm/

As suggested elsewhere, we could install commit-message-validator in the Codex repo, to help people write commit messages that comply with our guidelines.

ldelench_wmf moved this task from Inbox to Needs Refinement on the Design-System-Team board.
ldelench_wmf set the point value for this task to 3.Sep 19 2022, 3:41 PM