Page MenuHomePhabricator
Create Task
Maniphest T313559

Remove Vector grid feature flagging code
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Description

The wgVectorGrid configuration flag was used by T312241. It can safely be removed once origin/wmf/1.39.0-wmf.21 is enabled everywhere (At earliest 29th July 2022). Removing the code will lead to better performance (no legacy layout code loaded) and easier to work with code.

The legacy layout CSS was retained for cached HTML. It can safely be removed in origin/wmf/1.39.0-wmf.22 (earliest merge date Tuesday 27th)

TODO

  • Remove VectorGrid feature flag and associated code
  • Remove wgVectorGrid from mediawiki configuration (blocked on TODO #1)
  • Remove all instances of .vector-layout-legacy class selector (earliest 27th)
  • Replace all instances of .vector-toc-visible with .vector-layout-grid (earliest 27th)
  • Remove instances of .mw-workspace-container

Details

SubjectRepoBranchLines +/-
Remove Vector grid configoperations/mediawiki-configmaster+0 -4
Follow-up: Clean up left over vector legacy classesmediawiki/skins/Vectormaster+0 -5
Follow up: Remove .vector-layout-grid, .mw-workspace-container classesmediawiki/skins/Vectormaster+110 -129
Remove vector-layout-legacy styles and grid feature flagmediawiki/skins/Vectormaster+53 -357
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Jul 21 2022, 10:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 21 2022, 10:24 PM
Jdlrobson triaged this task as Medium priority.Jul 21 2022, 10:24 PM
Jdlrobson mentioned this in T312241: Deploy the new grid layout.
Jdlrobson renamed this task from Remove wgVectorGrid from mediawiki configuration to Clean up layout code now grid is deployed everywhere.Jul 21 2022, 10:39 PM
Jdlrobson updated the task description. (Show Details)
Legoktm edited projects, added Wikimedia-Site-requests; removed MediaWiki-Configuration.Jul 21 2022, 10:40 PM
Legoktm added a project: Vector (legacy skin).
Jdlrobson renamed this task from Clean up layout code now grid is deployed everywhere to Remove Vector grid feature flagging code.Jul 21 2022, 10:41 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.
Jdlrobson updated the task description. (Show Details)
bwang subscribed.Jul 25 2022, 5:42 PM

@Jdlrobson Do we need to keep .vector-layout-grid to begin with?

LGoto set the point value for this task to 3.Jul 25 2022, 5:43 PM
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.
Jdlrobson removed a project: Wikimedia-Site-requests.Jul 26 2022, 8:32 AM

@bwang no, once the branch is cut the class vector-layout-grid should no longer be needed, but run Pixel and beware CSS specificity when removing it. I personally would do this in stages - ie. merge vector-toc-visible and vector-layout-grid before removing it since there's a bit of risk with each stage here and it might lead to easier to read diffs.

bwang updated the task description. (Show Details)Jul 27 2022, 5:12 PM
bwang claimed this task.Aug 3 2022, 8:02 PM
bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.
gerritbot added a comment.Aug 3 2022, 8:56 PM

Change 820217 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Remove vector-layout-legacy styles and grid feature flag

https://gerrit.wikimedia.org/r/820217

gerritbot added a project: Patch-For-Review.Aug 3 2022, 8:56 PM
bwang removed bwang as the assignee of this task.Aug 5 2022, 2:31 PM
bwang moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.
gerritbot added a comment.Aug 5 2022, 2:32 PM

Change 820753 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Remove .vector-layout-grid, .mw-workspace-container classes

https://gerrit.wikimedia.org/r/820753

Jdlrobson assigned this task to Edtadros.Aug 8 2022, 5:02 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.
gerritbot added a comment.Aug 8 2022, 5:13 PM

Change 820217 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove vector-layout-legacy styles and grid feature flag

https://gerrit.wikimedia.org/r/820217

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 8 2022, 6:00 PM
gerritbot added a comment.Aug 15 2022, 6:52 PM

Change 820753 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Follow up: Remove .vector-layout-grid, .mw-workspace-container classes

https://gerrit.wikimedia.org/r/820753

Maintenance_bot removed a project: Patch-For-Review.Aug 15 2022, 7:30 PM
gerritbot added a comment.Aug 17 2022, 8:18 PM

Change 824280 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Follow-up: Clean up left over vector legacy classes

https://gerrit.wikimedia.org/r/824280

gerritbot added a project: Patch-For-Review.Aug 17 2022, 8:18 PM
gerritbot added a comment.Aug 17 2022, 8:38 PM

Change 824280 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Follow-up: Clean up left over vector legacy classes

https://gerrit.wikimedia.org/r/824280

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.26; 2022-08-22); removed MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 17 2022, 9:01 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 17 2022, 9:29 PM
Edtadros reassigned this task from Edtadros to ovasileva.Aug 25 2022, 2:49 AM
Edtadros subscribed.

I'm not sure how to verify this.

Jdlrobson moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Aug 26 2022, 7:26 AM

This can skip QA as it's a technical change. I'll sign off.

Jdlrobson claimed this task.Aug 29 2022, 5:12 PM
Jdlrobson added a subscriber: ovasileva.
Jdlrobson mentioned this in T311316: [Tech debt] Consolidate vector-toc-visible and vector-sidebar-container-no-toc.Aug 30 2022, 1:23 PM
Jdlrobson removed Jdlrobson as the assignee of this task.Aug 30 2022, 9:56 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Ready for Signoff to Needs More Work on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.

@bwang we still need to clean up configuration.

gerritbot added a comment.Aug 31 2022, 6:08 PM

Change 828616 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[operations/mediawiki-config@master] Remove Vector grid config

https://gerrit.wikimedia.org/r/828616

gerritbot added a project: Patch-For-Review.Aug 31 2022, 6:08 PM
Jdlrobson moved this task from Needs More Work to Ready for Signoff on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Aug 31 2022, 6:11 PM
Jdlrobson claimed this task.Aug 31 2022, 11:41 PM
gerritbot added a comment.Sep 1 2022, 8:43 PM

Change 828616 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove Vector grid config

https://gerrit.wikimedia.org/r/828616

Stashbot added a comment.Sep 1 2022, 8:44 PM

Mentioned in SAL (#wikimedia-operations) [2022-09-01T20:44:14Z] <thcipriani@deploy1002> Started scap: Backport for [[gerrit:828616|Remove Vector grid config (T313559)]], [[gerrit:829043|Disable sticky header edit experiment for idwiki, viwki (T315264)]]

Stashbot mentioned this in T315264: Disable sticky header edit A/B test for idwiki + viwiki.Sep 1 2022, 8:44 PM

Mentioned in SAL (#wikimedia-operations) [2022-09-01T20:44:42Z] <thcipriani@deploy1002> thcipriani and cjming and bwang: Backport for [[gerrit:828616|Remove Vector grid config (T313559)]], [[gerrit:829043|Disable sticky header edit experiment for idwiki, viwki (T315264)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet

Jdlrobson closed this task as Resolved.Sep 1 2022, 8:45 PM
Jdlrobson updated the task description. (Show Details)

Thanks all!

Stashbot added a comment.Sep 1 2022, 8:49 PM

Mentioned in SAL (#wikimedia-operations) [2022-09-01T20:49:58Z] <thcipriani@deploy1002> Finished scap: Backport for [[gerrit:828616|Remove Vector grid config (T313559)]], [[gerrit:829043|Disable sticky header edit experiment for idwiki, viwki (T315264)]] (duration: 05m 44s)

Maintenance_bot removed a project: Patch-For-Review.Sep 1 2022, 9:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL