Page MenuHomePhabricator
Create Task
Maniphest T313562

Design review the visual enhancement and layout changes
Closed, ResolvedPublic
Actions

Description

The release beginning the week of 25th sees various visual changes to Vector. With this in mind I think it makes sense to review all the changes together. All changes are live on the beta cluster.

To aid with this Pixel gives a visual regression summary of all the changes made this week:
https://pixel.wmcloud.org/reports/T313562/index.html

Please review all the changes and move this to sign off if everything looks good.

Expected changes

  • Search: Introduction of Codex (Bug: T300573, Bug: T302137, Bug: T303558, Bug: T309722, Bug: T310525)
  • Tabs: Changes to the language variant dropdown position ( Bug: T309223, Bug: T308344, Bug: T312212) and chevron (T308344, T310838)
  • Link: External link icon change (phab:T261391)
    • Footer, TOC: The new grid was rolled out resulting in changes to the footer and table of contents alignment (phab:T312241)
  • TOC: Changes to table of contents text alignment and padding (T312156)

Related Objects

Event Timeline

Jdlrobson created this task.Jul 21 2022, 10:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 21 2022, 10:54 PM
Jdlrobson triaged this task as High priority.Jul 21 2022, 10:55 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson assigned this task to • alexhollender_WMF.Jul 21 2022, 11:31 PM
Jdlrobson added a subscriber: • alexhollender_WMF.

The next release is quite risky from a design perspective as there have been a lot of design changes! Pixel is flagging 71/90 failures for test cases. I’ve done my best to describe the changes going out here @alexhollender_WMF I realize this is not our usual design process, but I think it makes sense given the unique situation we're in this week. Let me know if you have any questions about the next release.

Jdlrobson updated the task description. (Show Details)Jul 21 2022, 11:43 PM
ovasileva subscribed.Jul 22 2022, 8:44 AM

@Jdlrobson - unsure if this is related to the grid work, but seeing an overlap along the footer of the page:

Screen Shot 2022-07-22 at 9.43.20 AM.png (630×2 px, 303 KB)

Jdlrobson added a comment.Jul 22 2022, 2:33 PM
In T313562#8096942, @ovasileva wrote:

@Jdlrobson - unsure if this is related to the grid work, but seeing an overlap along the footer of the page:

Screen Shot 2022-07-22 at 9.43.20 AM.png (630×2 px, 303 KB)

This is T313060

Jdlrobson mentioned this in T312156: TOC styling update.Jul 22 2022, 3:19 PM
• alexhollender_WMF added a comment.Jul 26 2022, 7:59 PM

@Jdlrobson I'm having a difficult time understanding the pixel results.

Jdlrobson added a comment.Jul 27 2022, 7:11 PM

Per standup there's a bug where two different image sizes are compared. Please review these manually.

• alexhollender_WMF closed this task as Resolved.Aug 2 2022, 3:54 PM

i've reviewed the pixel screenshots and don't have any concerns

ovasileva removed • alexhollender_WMF as the assignee of this task.Dec 5 2022, 10:24 PM
ovasileva moved this task from Design Review to Ready for Signoff on the Web-Team-Backlog-Archived (Kanbanana-2022-23-Q1) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits